feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CppEditor: Consider operators

Browse Source 
... when looking for reimplemented member functions in the "Insert
virtual functions of base class" quickfix.

Fixes: QTCREATORBUG-12218
Change-Id: I6e37e28ab747a76dcc97df242bd6c6199fbc7e2e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Christian Kandeler
2020-07-27 17:11:39 +02:00
parent c467ae6114
commit 4e9951af3a
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/cppeditor/cppinsertvirtualmethods.cpp
View File

@@ -619,10 +619,12 @@ public:
// Do not implement existing functions inside target class // Do not implement existing functions inside target class
bool funcExistsInClass = false; bool funcExistsInClass = false;
const Name *funcName = func->name(); const Name *funcName = func->name();
for (Symbol *symbol = m_classAST->symbol->find(funcName->identifier()); const OperatorNameId * const opName = funcName->asOperatorNameId();
symbol; symbol = symbol->next()) { Symbol *symbol = opName ? m_classAST->symbol->find(opName->kind())
if (!symbol->name() : m_classAST->symbol->find(funcName->identifier());
|| !funcName->identifier()->match(symbol->identifier())) { for (; symbol; symbol = symbol->next()) {
if (!opName && (!symbol->name()
|| !funcName->identifier()->match(symbol->identifier()))) {
continue; continue;
} }
if (symbol->type().match(func->type())) { if (symbol->type().match(func->type())) {
@@ -1541,10 +1543,12 @@ void CppEditorPlugin::test_quickfix_InsertVirtualMethods_data()
"class BaseA {\n" "class BaseA {\n"
"public:\n" "public:\n"
" virtual int virtualFuncA();\n" " virtual int virtualFuncA();\n"
" virtual operator==(const BaseA &);\n"
"};\n\n" "};\n\n"
"class Derived : public Bas@eA {\n" "class Derived : public Bas@eA {\n"
"public:\n" "public:\n"
" virtual int virtualFuncA() = 0;\n" " virtual int virtualFuncA() = 0;\n"
" virtual operator==(const BaseA &);\n"
"};\n" "};\n"
) << _(); ) << _();