feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Code cosmetics

Browse Source 
Sprinkling in const and ranged for.

Change-Id: I5d11d57f64140021397c23734c7373544ebebb6f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2018-05-30 15:42:51 +02:00
parent 829df213a4
commit 4feb2259d9
29 changed files with 122 additions and 122 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/plugins/debugger/breakhandler.cpp
View File

@@ -1064,9 +1064,9 @@ void BreakHandler::saveBreakpoints()
void BreakHandler::loadBreakpoints()
{
QVariant value = sessionValue("Breakpoints");
QList<QVariant> list = value.toList();
foreach (const QVariant &var, list) {
const QVariant value = sessionValue("Breakpoints");
const QList<QVariant> list = value.toList();
for (const QVariant &var : list) {
const QMap<QString, QVariant> map = var.toMap();
BreakpointParameters params(BreakpointByFileAndLine);
QVariant v = map.value("filename");
@@ -1137,7 +1137,7 @@ Breakpoint BreakHandler::findBreakpointByIndex(const QModelIndex &index) const
Breakpoints BreakHandler::findBreakpointsByIndex(const QList<QModelIndex> &list) const
{
QSet<Breakpoint> ids;
foreach (const QModelIndex &index, list) {
for (const QModelIndex &index : list) {
if (Breakpoint b = findBreakpointByIndex(index))
ids.insert(b);
}
@@ -1830,19 +1830,19 @@ void BreakHandler::changeLineNumberFromMarkerHelper(BreakpointModelId id)
appendBreakpoint(params);
}
Breakpoints BreakHandler::allBreakpoints() const
const Breakpoints BreakHandler::allBreakpoints() const
{
Breakpoints items;
forItemsAtLevel<1>([&items](BreakpointItem *b) { items.append(Breakpoint(b)); });
return items;
}
Breakpoints BreakHandler::unclaimedBreakpoints() const
const Breakpoints BreakHandler::unclaimedBreakpoints() const
{
return engineBreakpoints(0);
}
Breakpoints BreakHandler::engineBreakpoints(DebuggerEngine *engine) const
const Breakpoints BreakHandler::engineBreakpoints(DebuggerEngine *engine) const
{
Breakpoints items;
forItemsAtLevel<1>([&items, engine](BreakpointItem *b) {
@@ -1930,7 +1930,7 @@ bool BreakHandler::setData(const QModelIndex &idx, const QVariant &value, int ro
const bool isEnabled = items.isEmpty() || items.at(0).isEnabled();
setBreakpointsEnabled(items, !isEnabled);
// FIXME
// foreach (const QModelIndex &id, selectedIds)
// for (const QModelIndex &id : selectedIds)
// update(id);
return true;
}
@@ -2069,7 +2069,7 @@ bool BreakHandler::contextMenuEvent(const ItemViewEvent &ev)
void BreakHandler::setBreakpointsEnabled(const Breakpoints &bps, bool enabled)
{
foreach (Breakpoint b, bps)
for (Breakpoint b : bps)
b.setEnabled(enabled);
}
@@ -2088,7 +2088,7 @@ void BreakHandler::deleteAllBreakpoints()
void BreakHandler::deleteBreakpoints(const Breakpoints &bps)
{
foreach (Breakpoint bp, bps)
for (Breakpoint bp : bps)
bp.removeBreakpoint();
}
@@ -2141,7 +2141,7 @@ void BreakHandler::editBreakpoints(const Breakpoints &bps, QWidget *parent)
const int newIgnoreCount = dialog.ignoreCount();
const int newThreadSpec = dialog.threadSpec();
foreach (Breakpoint bp, bps) {
for (Breakpoint bp : bps) {
if (bp) {
bp.setCondition(newCondition);
bp.setIgnoreCount(newIgnoreCount);