From 500b5e20b5796b9ea018afd8b53e5ec62f962c64 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thorbj=C3=B8rn=20Lindeijer?= Date: Wed, 15 Apr 2009 16:06:49 +0200 Subject: [PATCH] No need to open file ReadWrite for just reading its contents Pointed out by Mathias Gumz. --- src/plugins/coreplugin/filemanager.cpp | 2 +- src/plugins/texteditor/basetextdocument.cpp | 5 +---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/plugins/coreplugin/filemanager.cpp b/src/plugins/coreplugin/filemanager.cpp index b996ed50407..a13c72accc3 100644 --- a/src/plugins/coreplugin/filemanager.cpp +++ b/src/plugins/coreplugin/filemanager.cpp @@ -453,7 +453,7 @@ void FileManager::changedFile(const QString &file) foreach (IFile *fileinterface, managedFiles(file)) m_changedFiles << fileinterface; if (wasempty && !m_changedFiles.isEmpty()) { - QTimer::singleShot (200, this, SLOT(checkForReload())); + QTimer::singleShot(200, this, SLOT(checkForReload())); } } diff --git a/src/plugins/texteditor/basetextdocument.cpp b/src/plugins/texteditor/basetextdocument.cpp index 7106b03550e..f22bc2a8385 100755 --- a/src/plugins/texteditor/basetextdocument.cpp +++ b/src/plugins/texteditor/basetextdocument.cpp @@ -171,10 +171,7 @@ bool BaseTextDocument::open(const QString &fileName) m_fileName = fi.absoluteFilePath(); QFile file(fileName); - if (!file.exists()) - return false; - - if (!file.open(QIODevice::ReadWrite) && !file.open(QIODevice::ReadOnly)) + if (!file.open(QIODevice::ReadOnly)) return false; title = fi.fileName();