feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

BareMetal: Remove unused deployment step

Browse Source 
Was apparently not really needed and can be easily
re-added nowadays.

Change-Id: Ib7f46f7b8ea0624d0d3f12a8ef42092dd51d78d5
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
This commit is contained in:
hjk
2019-06-25 16:33:47 +02:00
parent 7dc1b39a61
commit 5026d21c4e
4 changed files with 0 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/baremetal/CMakeLists.txt
View File

@@ -10,7 +10,6 @@ add_qtc_plugin(BareMetal
baremetaldeviceconfigurationwidget.cpp baremetaldeviceconfigurationwidget.h
baremetaldeviceconfigurationwizard.cpp baremetaldeviceconfigurationwizard.h
baremetaldeviceconfigurationwizardpages.cpp baremetaldeviceconfigurationwizardpages.h
baremetalgdbcommandsdeploystep.cpp baremetalgdbcommandsdeploystep.h
baremetalplugin.cpp baremetalplugin.h
baremetalrunconfiguration.cpp baremetalrunconfiguration.h
defaultgdbserverprovider.cpp defaultgdbserverprovider.h

2
src/plugins/baremetal/baremetal.pro
View File

@@ -7,7 +7,6 @@ SOURCES += baremetalplugin.cpp \
baremetalcustomrunconfiguration.cpp\
baremetaldevice.cpp \
baremetalrunconfiguration.cpp \
baremetalgdbcommandsdeploystep.cpp \
baremetaldeviceconfigurationwizardpages.cpp \
baremetaldeviceconfigurationwizard.cpp \
baremetaldeviceconfigurationwidget.cpp \
@@ -32,7 +31,6 @@ HEADERS += baremetalplugin.h \
baremetalcustomrunconfiguration.h \
baremetaldevice.h \
baremetalrunconfiguration.h \
baremetalgdbcommandsdeploystep.h \
baremetaldeviceconfigurationwidget.h \
baremetaldeviceconfigurationwizard.h \
baremetaldeviceconfigurationwizardpages.h \

1
src/plugins/baremetal/baremetal.qbs
View File

@@ -20,7 +20,6 @@ QtcPlugin {
"baremetaldeviceconfigurationwidget.cpp", "baremetaldeviceconfigurationwidget.h",
"baremetaldeviceconfigurationwizard.cpp", "baremetaldeviceconfigurationwizard.h",
"baremetaldeviceconfigurationwizardpages.cpp", "baremetaldeviceconfigurationwizardpages.h",
"baremetalgdbcommandsdeploystep.cpp", "baremetalgdbcommandsdeploystep.h",
"baremetalplugin.cpp", "baremetalplugin.h",
"baremetalrunconfiguration.cpp", "baremetalrunconfiguration.h",
"baremetaldebugsupport.cpp", "baremetaldebugsupport.h",

17
src/plugins/baremetal/baremetaldebugsupport.cpp
View File

@@ -25,7 +25,6 @@
#include "baremetaldebugsupport.h"
#include "baremetaldevice.h"
#include "baremetalgdbcommandsdeploystep.h"
#include "gdbserverprovider.h"
#include "gdbserverprovidermanager.h"
@@ -105,22 +104,6 @@ void BareMetalDebugSupport::start()
const GdbServerProvider *p = GdbServerProviderManager::findProvider(dev->gdbServerProviderId());
QTC_ASSERT(p, reportFailure(); return);
#if 0
// Currently baremetal plugin does not provide way to configure deployments steps
// FIXME: Should it?
QString commands;
if (const BuildConfiguration *bc = target->activeBuildConfiguration()) {
if (BuildStepList *bsl = bc->stepList(BareMetalGdbCommandsDeployStep::stepId())) {
for (const BareMetalGdbCommandsDeployStep *bs : bsl->allOfType<BareMetalGdbCommandsDeployStep>()) {
if (!commands.endsWith("\n"))
commands.append("\n");
commands.append(bs->gdbCommands());
}
}
}
setCommandsAfterConnect(commands);
#endif
Runnable inferior;
inferior.executable = bin;
if (const auto aspect = runControl()->aspect<ArgumentsAspect>())