feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Gerrit: Minor cleanup

Browse Source 
* Remove unused member
* Inline function that is used only once
* Replace slots with lambdas

Change-Id: I6887b115463c9aac24d4c3dfe6a70357c9068973
Reviewed-by: André Hartmann <aha_1980@gmx.de>
This commit is contained in:
Orgad Shaneh
2017-01-14 22:51:47 +02:00
committed by Orgad Shaneh
parent 22ac7534a5
commit 5035807f89
5 changed files with 8 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/git/gerrit/gerritmodel.cpp
View File

@@ -239,7 +239,6 @@ private:
void errorTermination(const QString &msg);
void terminate();
const QSharedPointer<GerritParameters> m_parameters;
const QStringList m_queries;
QProcess m_process;
QTimer m_timer;
@@ -257,10 +256,9 @@ QueryContext::QueryContext(const QStringList &queries,
const QSharedPointer<GerritParameters> &p,
QObject *parent)
: QObject(parent)
, m_parameters(p)
, m_queries(queries)
, m_currentQuery(0)
, m_baseArguments(p->baseCommandArguments())
, m_baseArguments({ p->ssh, p->portFlag, QString::number(p->port), p->sshHostArgument(), "gerrit" })
{
connect(&m_process, &QProcess::readyReadStandardError,
this, &QueryContext::readyReadStandardError);