From 50557abd03cb57ec414b9e7d15c154b6748eccfa Mon Sep 17 00:00:00 2001
From: Thomas Hartmann <Thomas.Hartmann@qt.io>
Date: Tue, 5 Oct 2021 10:29:32 +0200
Subject: [PATCH] QmlDesigner: Fix crash
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

If the target cannot be resolved the result is invalid.

Task-number: QDS-5216
Change-Id: Ibd7884d6638ae653953347862ca1291f963aa3b3
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
---
 .../qmldesigner/components/stateseditor/stateseditorview.cpp    | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/plugins/qmldesigner/components/stateseditor/stateseditorview.cpp b/src/plugins/qmldesigner/components/stateseditor/stateseditorview.cpp
index 12fff40c798..997852cfb25 100644
--- a/src/plugins/qmldesigner/components/stateseditor/stateseditorview.cpp
+++ b/src/plugins/qmldesigner/components/stateseditor/stateseditorview.cpp
@@ -46,6 +46,7 @@
 #include <qmlstate.h>
 #include <annotationeditor/annotationeditor.h>
 #include <utils/algorithm.h>
+#include <utils/qtcassert.h>
 
 
 namespace QmlDesigner {
@@ -103,6 +104,7 @@ void StatesEditorView::removeState(int nodeId)
                 const auto propertyChanges = modelState.propertyChanges();
                 for (const QmlPropertyChanges &change : propertyChanges) {
                     const ModelNode target = change.target();
+                    QTC_ASSERT(target.isValid(), continue);
                     if (target.locked())
                         lockedTargets.push_back(target.id());
                 }