feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Avoid unnecessary updated of item library model

Browse Source 
We call delayedUpdateModel() instead of updateModel() setItemLibraryInfo(),
to avoid a second update. The updateModel in updateImports() is not required,
since we call setItemLibraryInfo().

Change-Id: I2fbb4f9d0cd467776141ae4d0c8aaecb00f55557
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Thomas Hartmann
2016-11-07 11:06:10 +01:00
committed by Thomas Hartmann
parent 9b09bf62bd
commit 50c63a78b8
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/qmldesigner/components/itemlibrary/itemlibrarywidget.cpp
View File

@@ -170,8 +170,7 @@ void ItemLibraryWidget::setItemLibraryInfo(ItemLibraryInfo *itemLibraryInfo)
if (itemLibraryInfo) if (itemLibraryInfo)
connect(m_itemLibraryInfo.data(), SIGNAL(entriesChanged()), connect(m_itemLibraryInfo.data(), SIGNAL(entriesChanged()),
this, SLOT(delayedUpdateModel())); this, SLOT(delayedUpdateModel()));
delayedUpdateModel();
updateModel();
} }
void ItemLibraryWidget::updateImports() void ItemLibraryWidget::updateImports()
@@ -229,7 +228,6 @@ void ItemLibraryWidget::setModel(Model *model)
if (!model) if (!model)
return; return;
setItemLibraryInfo(model->metaInfo().itemLibraryInfo()); setItemLibraryInfo(model->metaInfo().itemLibraryInfo());
updateModel();
} }
void ItemLibraryWidget::setCurrentIndexOfStackedWidget(int index) void ItemLibraryWidget::setCurrentIndexOfStackedWidget(int index)