From 50ebf1f82423e5586f8a850c8eccd6d5610a0789 Mon Sep 17 00:00:00 2001 From: Alessandro Portale Date: Thu, 15 Dec 2022 15:58:52 +0100 Subject: [PATCH] Utils: Show macroExpander icon only on non-readOnly StringAspects Change-Id: Ib9c22c8e7b73c166452b4b18341fc81673c55535 Reviewed-by: hjk --- src/libs/utils/variablechooser.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/libs/utils/variablechooser.cpp b/src/libs/utils/variablechooser.cpp index c24cbbdb8ed..eefb8a83c92 100644 --- a/src/libs/utils/variablechooser.cpp +++ b/src/libs/utils/variablechooser.cpp @@ -488,11 +488,12 @@ void VariableChooserPrivate::updateCurrentEditor(QWidget *old, QWidget *widget) m_currentVariableName = widget->property(kVariableNameProperty).toByteArray(); bool supportsVariables = chooser == q; if (auto lineEdit = qobject_cast(widget)) - m_lineEdit = (supportsVariables ? lineEdit : nullptr); + m_lineEdit = (supportsVariables && !lineEdit->isReadOnly() ? lineEdit : nullptr); else if (auto textEdit = qobject_cast(widget)) - m_textEdit = (supportsVariables ? textEdit : nullptr); + m_textEdit = (supportsVariables && !textEdit->isReadOnly() ? textEdit : nullptr); else if (auto plainTextEdit = qobject_cast(widget)) - m_plainTextEdit = (supportsVariables ? plainTextEdit : nullptr); + m_plainTextEdit = (supportsVariables && !plainTextEdit->isReadOnly() ? + plainTextEdit : nullptr); QWidget *current = currentWidget(); if (current != previousWidget) {