feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Python: Plugin code cosmetics

Browse Source 
Use the common pattern for PythonEditorPluginPrivate.

Change-Id: Icec8d975e0ab921be7121d123af4dddecd7d0384
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2018-04-26 17:42:07 +02:00
parent f0baf01a2e
commit 50f2bcd9ae
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/pythoneditor/pythoneditorplugin.cpp
View File

@@ -654,12 +654,9 @@ public:
PythonRunConfigurationFactory runConfigFactory; PythonRunConfigurationFactory runConfigFactory;
}; };
static PythonEditorPluginPrivate *dd = nullptr;
PythonEditorPlugin::~PythonEditorPlugin() PythonEditorPlugin::~PythonEditorPlugin()
{ {
delete dd; delete d;
dd = nullptr;
} }
bool PythonEditorPlugin::initialize(const QStringList &arguments, QString *errorMessage) bool PythonEditorPlugin::initialize(const QStringList &arguments, QString *errorMessage)
@@ -667,7 +664,7 @@ bool PythonEditorPlugin::initialize(const QStringList &arguments, QString *error
Q_UNUSED(arguments) Q_UNUSED(arguments)
Q_UNUSED(errorMessage) Q_UNUSED(errorMessage)
dd = new PythonEditorPluginPrivate; d = new PythonEditorPluginPrivate;
ProjectManager::registerProjectType<PythonProject>(PythonMimeType); ProjectManager::registerProjectType<PythonProject>(PythonMimeType);

9
src/plugins/pythoneditor/pythoneditorplugin.h
View File

@@ -37,10 +37,13 @@ class PythonEditorPlugin : public ExtensionSystem::IPlugin
public: public:
PythonEditorPlugin() = default; PythonEditorPlugin() = default;
~PythonEditorPlugin() override; ~PythonEditorPlugin() final;
bool initialize(const QStringList &arguments, QString *errorMessage) override; private:
void extensionsInitialized() override; bool initialize(const QStringList &arguments, QString *errorMessage) final;
void extensionsInitialized() final;
class PythonEditorPluginPrivate *d = nullptr;
}; };
} // namespace Internal } // namespace Internal