feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Limit the usage of std::make_pair

Browse Source 
Make the code less verbose.

Change-Id: I4d671a49a6b8097d4a324bdd9f6a2c9dbdb225cc
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Jarek Kobus
2022-09-30 15:17:36 +02:00
parent aedd50eeb7
commit 50f2f57f6a
2 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/projectexplorer/jsonwizard/jsonwizardfactory.cpp
View File

@@ -300,7 +300,7 @@ std::pair<int, QStringList> JsonWizardFactory::screenSizeInfoFromPage(const QStr
if (values.isEmpty()) if (values.isEmpty())
return {}; return {};
return std::make_pair(index, values); return {index, values};
} }
JsonWizardFactory::Page JsonWizardFactory::parsePage(const QVariant &value, QString *errorMessage) JsonWizardFactory::Page JsonWizardFactory::parsePage(const QVariant &value, QString *errorMessage)

8
src/plugins/projectexplorer/toolchain.cpp
View File

@@ -685,11 +685,9 @@ static QString badToolchainTimestampKey() { return {"Timestamp"}; }
QVariantMap BadToolchain::toMap() const QVariantMap BadToolchain::toMap() const
{ {
return { return {{badToolchainFilePathKey(), filePath.toVariant()},
std::make_pair(badToolchainFilePathKey(), filePath.toVariant()), {badToolchainSymlinkTargetKey(), symlinkTarget.toVariant()},
std::make_pair(badToolchainSymlinkTargetKey(), symlinkTarget.toVariant()), {badToolchainTimestampKey(), timestamp.toMSecsSinceEpoch()}};
std::make_pair(badToolchainTimestampKey(), timestamp.toMSecsSinceEpoch()),
};
} }
BadToolchain BadToolchain::fromMap(const QVariantMap &map) BadToolchain BadToolchain::fromMap(const QVariantMap &map)