feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

TextEditor: Fix potential memory leak in code assist

Browse Source 
Manually managing the ownership of the code assist objets gets messy. We
should use smart pointers.

Change-Id: I29fe665e52438a79c3268b74898c583bb302f1fc
Reviewed-by: Erik Verbruggen <erik.verbruggen@theqtcompany.com>
This commit is contained in:
Nikolai Kosjar
2015-07-29 12:28:19 +02:00
parent f4796d0032
commit 5145fc8509
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/texteditor/codeassist/codeassistant.cpp
View File

@@ -229,8 +229,10 @@ void CodeAssistantPrivate::requestProposal(AssistReason reason,
m_assistKind = kind; m_assistKind = kind;
IAssistProcessor *processor = provider->createProcessor(); IAssistProcessor *processor = provider->createProcessor();
AssistInterface *assistInterface = m_editorWidget->createAssistInterface(kind, reason); AssistInterface *assistInterface = m_editorWidget->createAssistInterface(kind, reason);
if (!assistInterface) if (!assistInterface) {
delete processor;
return; return;
}
switch (provider->runType()) { switch (provider->runType()) {
case IAssistProvider::Synchronous: { case IAssistProvider::Synchronous: {