CompilerExplorer: Inline compilerexplorerplugin.h

Makes adding unwanted functionality in this place harder.

Change-Id: I2b36414b4bf6a58deff3c565936d433ebcdc9d5f
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>

src/plugins/compilerexplorer/CMakeLists.txt

@@ -17,7 +17,6 @@ add_qtc_plugin(CompilerExplorer
     compilerexploreraspects.cpp
     compilerexploreraspects.h
     compilerexplorerplugin.cpp
-    compilerexplorerplugin.h
     compilerexplorertr.h
     compilerexplorereditor.cpp
     compilerexplorereditor.h

src/plugins/compilerexplorer/compilerexplorer.qbs

@@ -30,7 +30,6 @@ QtcPlugin {
         "compilerexploreroptions.cpp",
         "compilerexploreroptions.h",
         "compilerexplorerplugin.cpp",
-        "compilerexplorerplugin.h",
         "compilerexplorersettings.cpp",
         "compilerexplorersettings.h",
         "compilerexplorertr.h",

src/plugins/compilerexplorer/compilerexplorerplugin.cpp

@@ -1,8 +1,6 @@
 // Copyright (C) 2023 The Qt Company Ltd.
 // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0
 
-#include "compilerexplorerplugin.h"
-
 #include "compilerexplorerconstants.h"
 #include "compilerexplorereditor.h"
 #include "compilerexplorersettings.h"
@@ -18,14 +16,22 @@
 
 #include <QMenu>
 
-namespace CompilerExplorer {
+#include <extensionsystem/iplugin.h>
-namespace Internal {
 
-CompilerExplorerPlugin::CompilerExplorerPlugin() {}
+using namespace Core;
 
-CompilerExplorerPlugin::~CompilerExplorerPlugin() {}
+namespace CompilerExplorer::Internal {
 
-void CompilerExplorerPlugin::initialize()
+class CompilerExplorerPlugin : public ExtensionSystem::IPlugin
+{
+    Q_OBJECT
+    Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "CompilerExplorer.json")
+
+public:
+    CompilerExplorerPlugin();
+    ~CompilerExplorerPlugin() override;
+
+    void initialize() override
     {
         static CompilerExplorer::EditorFactory ceEditorFactory;
 
@@ -35,22 +41,20 @@ void CompilerExplorerPlugin::initialize()
 
             const QString src = settings.source();
             QString name("Compiler Explorer");
-        Core::EditorManager::openEditorWithContents(Constants::CE_EDITOR_ID, &name, src.toUtf8());
+            EditorManager::openEditorWithContents(Constants::CE_EDITOR_ID, &name, src.toUtf8());
         });
 
-    Core::ActionContainer *mtools = Core::ActionManager::actionContainer(Core::Constants::M_TOOLS);
+        ActionContainer *mtools = ActionManager::actionContainer(Core::Constants::M_TOOLS);
-    Core::ActionContainer *mCompilerExplorer = Core::ActionManager::createMenu(
+        ActionContainer *mCompilerExplorer = ActionManager::createMenu("Tools.CompilerExplorer");
-        "Tools.CompilerExplorer");
         QMenu *menu = mCompilerExplorer->menu();
         menu->setTitle(Tr::tr("Compiler Explorer"));
         mtools->addMenu(mCompilerExplorer);
 
-    Core::Command *cmd
+        Command *cmd = ActionManager::registerAction(action, "CompilerExplorer.CompilerExplorerAction");
-        = Core::ActionManager::registerAction(action, "CompilerExplorer.CompilerExplorerAction");
         mCompilerExplorer->addAction(cmd);
     }
+};
 
-void CompilerExplorerPlugin::extensionsInitialized() {}
+} // CompilerExplorer::Internl
 
-} // namespace Internal
+#include "compilerexplorerplugin.moc"
-} // namespace CompilerExplorer

src/plugins/compilerexplorer/compilerexplorerplugin.h

@@ -1,24 +0,0 @@
-// Copyright (C) 2023 The Qt Company Ltd.
-// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0
-
-#pragma once
-
-#include <extensionsystem/iplugin.h>
-
-namespace CompilerExplorer::Internal {
-
-class CompilerExplorerPlugin : public ExtensionSystem::IPlugin
-{
-    Q_OBJECT
-    Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "CompilerExplorer.json")
-
-public:
-    CompilerExplorerPlugin();
-    ~CompilerExplorerPlugin() override;
-
-    void initialize() override;
-
-    void extensionsInitialized() override;
-};
-
-} // namespace CompilerExplorer::Internal