diff --git a/src/plugins/android/androidrunconfiguration.cpp b/src/plugins/android/androidrunconfiguration.cpp index 1d7828b5369..7b642f036e7 100644 --- a/src/plugins/android/androidrunconfiguration.cpp +++ b/src/plugins/android/androidrunconfiguration.cpp @@ -114,15 +114,15 @@ AndroidRunConfiguration::AndroidRunConfiguration(Target *target, Utils::Id id) addAspect(); - auto amStartArgsAspect = addAspect(); + auto amStartArgsAspect = addAspect(); amStartArgsAspect->setId(Constants::ANDROID_AMSTARTARGS); amStartArgsAspect->setSettingsKey("Android.AmStartArgsKey"); amStartArgsAspect->setLabelText(tr("Activity manager start options:")); - amStartArgsAspect->setDisplayStyle(BaseStringAspect::LineEditDisplay); + amStartArgsAspect->setDisplayStyle(StringAspect::LineEditDisplay); amStartArgsAspect->setHistoryCompleter("Android.AmStartArgs.History"); - auto warning = addAspect(); - warning->setDisplayStyle(BaseStringAspect::LabelDisplay); + auto warning = addAspect(); + warning->setDisplayStyle(StringAspect::LabelDisplay); warning->setLabelPixmap(Icons::WARNING.pixmap()); warning->setValue(tr("If the \"am start\" options conflict, the application might not start.\n" "%1 uses: am start -n / [-D].") diff --git a/src/plugins/android/androidrunnerworker.cpp b/src/plugins/android/androidrunnerworker.cpp index 0f31535b057..a1ec359a81b 100644 --- a/src/plugins/android/androidrunnerworker.cpp +++ b/src/plugins/android/androidrunnerworker.cpp @@ -289,7 +289,7 @@ AndroidRunnerWorker::AndroidRunnerWorker(RunWorker *runner, const QString &packa m_extraAppParams = runControl->runnable().commandLineArguments; if (auto aspect = runControl->aspect(Constants::ANDROID_AMSTARTARGS)) { - const QString startArgs = static_cast(aspect)->value(); + const QString startArgs = static_cast(aspect)->value(); m_amStartExtraArgs = QtcProcess::splitArgs(startArgs, OsTypeOtherUnix); } diff --git a/src/plugins/autotoolsprojectmanager/autogenstep.cpp b/src/plugins/autotoolsprojectmanager/autogenstep.cpp index 3b093dc36aa..5336c90b08a 100644 --- a/src/plugins/autotoolsprojectmanager/autogenstep.cpp +++ b/src/plugins/autotoolsprojectmanager/autogenstep.cpp @@ -66,7 +66,7 @@ private: bool init() override; void doRun() override; - BaseStringAspect *m_additionalArgumentsAspect = nullptr; + StringAspect *m_additionalArgumentsAspect = nullptr; bool m_runAutogen = false; }; @@ -74,11 +74,11 @@ AutogenStep::AutogenStep(BuildStepList *bsl, Utils::Id id) : AbstractProcessStep { setDefaultDisplayName(tr("Autogen")); - m_additionalArgumentsAspect = addAspect(); + m_additionalArgumentsAspect = addAspect(); m_additionalArgumentsAspect->setSettingsKey( "AutotoolsProjectManager.AutogenStep.AdditionalArguments"); m_additionalArgumentsAspect->setLabelText(tr("Arguments:")); - m_additionalArgumentsAspect->setDisplayStyle(BaseStringAspect::LineEditDisplay); + m_additionalArgumentsAspect->setDisplayStyle(StringAspect::LineEditDisplay); m_additionalArgumentsAspect->setHistoryCompleter("AutotoolsPM.History.AutogenStepArgs"); connect(m_additionalArgumentsAspect, &ProjectConfigurationAspect::changed, this, [this] { diff --git a/src/plugins/autotoolsprojectmanager/autoreconfstep.cpp b/src/plugins/autotoolsprojectmanager/autoreconfstep.cpp index 78b93fb1079..2fb9cf49897 100644 --- a/src/plugins/autotoolsprojectmanager/autoreconfstep.cpp +++ b/src/plugins/autotoolsprojectmanager/autoreconfstep.cpp @@ -63,7 +63,7 @@ public: void doRun() override; private: - BaseStringAspect *m_additionalArgumentsAspect = nullptr; + StringAspect *m_additionalArgumentsAspect = nullptr; bool m_runAutoreconf = false; }; @@ -72,11 +72,11 @@ AutoreconfStep::AutoreconfStep(BuildStepList *bsl, Utils::Id id) { setDefaultDisplayName(tr("Autoreconf")); - m_additionalArgumentsAspect = addAspect(); + m_additionalArgumentsAspect = addAspect(); m_additionalArgumentsAspect->setSettingsKey("AutotoolsProjectManager.AutoreconfStep.AdditionalArguments"); m_additionalArgumentsAspect->setLabelText(tr("Arguments:")); m_additionalArgumentsAspect->setValue("--force --install"); - m_additionalArgumentsAspect->setDisplayStyle(BaseStringAspect::LineEditDisplay); + m_additionalArgumentsAspect->setDisplayStyle(StringAspect::LineEditDisplay); m_additionalArgumentsAspect->setHistoryCompleter("AutotoolsPM.History.AutoreconfStepArgs"); connect(m_additionalArgumentsAspect, &ProjectConfigurationAspect::changed, this, [this] { diff --git a/src/plugins/autotoolsprojectmanager/configurestep.cpp b/src/plugins/autotoolsprojectmanager/configurestep.cpp index d418c9c42bb..7bb1368496e 100644 --- a/src/plugins/autotoolsprojectmanager/configurestep.cpp +++ b/src/plugins/autotoolsprojectmanager/configurestep.cpp @@ -85,7 +85,7 @@ private: bool init() override; void doRun() override; - ProjectExplorer::BaseStringAspect *m_additionalArgumentsAspect = nullptr; + ProjectExplorer::StringAspect *m_additionalArgumentsAspect = nullptr; bool m_runConfigure = false; }; @@ -94,8 +94,8 @@ ConfigureStep::ConfigureStep(BuildStepList *bsl, Utils::Id id) { setDefaultDisplayName(tr("Configure")); - m_additionalArgumentsAspect = addAspect(); - m_additionalArgumentsAspect->setDisplayStyle(BaseStringAspect::LineEditDisplay); + m_additionalArgumentsAspect = addAspect(); + m_additionalArgumentsAspect->setDisplayStyle(StringAspect::LineEditDisplay); m_additionalArgumentsAspect->setSettingsKey( "AutotoolsProjectManager.ConfigureStep.AdditionalArguments"); m_additionalArgumentsAspect->setLabelText(tr("Arguments:")); diff --git a/src/plugins/baremetal/baremetalrunconfiguration.cpp b/src/plugins/baremetal/baremetalrunconfiguration.cpp index 6a38e5d96e4..913f1f3448f 100644 --- a/src/plugins/baremetal/baremetalrunconfiguration.cpp +++ b/src/plugins/baremetal/baremetalrunconfiguration.cpp @@ -49,7 +49,7 @@ public: : RunConfiguration(target, id) { const auto exeAspect = addAspect(); - exeAspect->setDisplayStyle(BaseStringAspect::LabelDisplay); + exeAspect->setDisplayStyle(StringAspect::LabelDisplay); exeAspect->setPlaceHolderText(tr("Unknown")); addAspect(); @@ -75,7 +75,7 @@ public: const auto exeAspect = addAspect(); exeAspect->setSettingsKey("BareMetal.CustomRunConfig.Executable"); exeAspect->setPlaceHolderText(tr("Unknown")); - exeAspect->setDisplayStyle(BaseStringAspect::PathChooserDisplay); + exeAspect->setDisplayStyle(StringAspect::PathChooserDisplay); exeAspect->setHistoryCompleter("BareMetal.CustomRunConfig.History"); exeAspect->setExpectedKind(PathChooser::Any); diff --git a/src/plugins/boot2qt/qdbmakedefaultappstep.cpp b/src/plugins/boot2qt/qdbmakedefaultappstep.cpp index c43fa0970cb..c371704b8d1 100644 --- a/src/plugins/boot2qt/qdbmakedefaultappstep.cpp +++ b/src/plugins/boot2qt/qdbmakedefaultappstep.cpp @@ -54,7 +54,7 @@ QdbMakeDefaultAppStep::QdbMakeDefaultAppStep(BuildStepList *bsl, Utils::Id id) auto service = createDeployService(); - auto selection = addAspect(); + auto selection = addAspect(); selection->setSettingsKey("QdbMakeDefaultDeployStep.MakeDefault"); selection->addOption(tr("Set this application to start by default")); selection->addOption(tr("Reset default application")); diff --git a/src/plugins/boot2qt/qdbrunconfiguration.cpp b/src/plugins/boot2qt/qdbrunconfiguration.cpp index e47460e8f4a..331cd864ca9 100644 --- a/src/plugins/boot2qt/qdbrunconfiguration.cpp +++ b/src/plugins/boot2qt/qdbrunconfiguration.cpp @@ -44,7 +44,7 @@ namespace Internal { // FullCommandLineAspect -class FullCommandLineAspect : public BaseStringAspect +class FullCommandLineAspect : public StringAspect { Q_DECLARE_TR_FUNCTIONS(Qdb::Internal::QdbRunConfiguration); diff --git a/src/plugins/cmakeprojectmanager/cmakebuildconfiguration.h b/src/plugins/cmakeprojectmanager/cmakebuildconfiguration.h index 32a1b7278a6..74a76251f41 100644 --- a/src/plugins/cmakeprojectmanager/cmakebuildconfiguration.h +++ b/src/plugins/cmakeprojectmanager/cmakebuildconfiguration.h @@ -126,7 +126,7 @@ private: friend class CMakeProjectImporter; }; -class InitialCMakeArgumentsAspect final : public ProjectExplorer::BaseStringAspect +class InitialCMakeArgumentsAspect final : public ProjectExplorer::StringAspect { Q_OBJECT diff --git a/src/plugins/debugger/debuggerrunconfigurationaspect.cpp b/src/plugins/debugger/debuggerrunconfigurationaspect.cpp index fc27b57528f..4f8820a27d6 100644 --- a/src/plugins/debugger/debuggerrunconfigurationaspect.cpp +++ b/src/plugins/debugger/debuggerrunconfigurationaspect.cpp @@ -203,14 +203,14 @@ DebuggerRunConfigurationAspect::DebuggerRunConfigurationAspect(Target *target) m_cppAspect->setValue(true); }); - m_multiProcessAspect = new BaseBoolAspect; + m_multiProcessAspect = new BoolAspect; m_multiProcessAspect->setSettingsKey("RunConfiguration.UseMultiProcess"); m_multiProcessAspect->setLabel(tr("Enable Debugging of Subprocesses"), - BaseBoolAspect::LabelPlacement::AtCheckBox); + BoolAspect::LabelPlacement::AtCheckBox); - m_overrideStartupAspect = new BaseStringAspect; + m_overrideStartupAspect = new StringAspect; m_overrideStartupAspect->setSettingsKey("RunConfiguration.OverrideDebuggerStartup"); - m_overrideStartupAspect->setDisplayStyle(BaseStringAspect::TextEditDisplay); + m_overrideStartupAspect->setDisplayStyle(StringAspect::TextEditDisplay); m_overrideStartupAspect->setLabelText(tr("Additional startup commands:")); } diff --git a/src/plugins/debugger/debuggerrunconfigurationaspect.h b/src/plugins/debugger/debuggerrunconfigurationaspect.h index 58619ee3ef1..63d5dc3b3f7 100644 --- a/src/plugins/debugger/debuggerrunconfigurationaspect.h +++ b/src/plugins/debugger/debuggerrunconfigurationaspect.h @@ -59,8 +59,8 @@ public: private: Internal::DebuggerLanguageAspect *m_cppAspect; Internal::DebuggerLanguageAspect *m_qmlAspect; - ProjectExplorer::BaseBoolAspect *m_multiProcessAspect; - ProjectExplorer::BaseStringAspect *m_overrideStartupAspect; + ProjectExplorer::BoolAspect *m_multiProcessAspect; + ProjectExplorer::StringAspect *m_overrideStartupAspect; ProjectExplorer::Target *m_target; }; diff --git a/src/plugins/incredibuild/buildconsolebuildstep.cpp b/src/plugins/incredibuild/buildconsolebuildstep.cpp index 9d5cc5636ba..283fca9bd34 100644 --- a/src/plugins/incredibuild/buildconsolebuildstep.cpp +++ b/src/plugins/incredibuild/buildconsolebuildstep.cpp @@ -81,25 +81,25 @@ public: private: CommandBuilderAspect *m_commandBuilder; - BaseBoolAspect *m_avoidLocal{nullptr}; - BaseStringAspect *m_profileXml{nullptr}; - BaseIntegerAspect *m_maxCpu{nullptr}; - BaseSelectionAspect *m_maxWinVer{nullptr}; - BaseSelectionAspect *m_minWinVer{nullptr}; - BaseStringAspect *m_title{nullptr}; - BaseStringAspect *m_monFile{nullptr}; - BaseBoolAspect *m_suppressStdOut{nullptr}; - BaseStringAspect *m_logFile{nullptr}; - BaseBoolAspect *m_showCmd{nullptr}; - BaseBoolAspect *m_showAgents{nullptr}; - BaseBoolAspect *m_showTime{nullptr}; - BaseBoolAspect *m_hideHeader{nullptr}; - BaseSelectionAspect *m_logLevel{nullptr}; - BaseStringAspect *m_setEnv{nullptr}; - BaseBoolAspect *m_stopOnError{nullptr}; - BaseStringAspect *m_additionalArguments{nullptr}; - BaseBoolAspect *m_openMonitor{nullptr}; - BaseBoolAspect *m_keepJobNum{nullptr}; + BoolAspect *m_avoidLocal{nullptr}; + StringAspect *m_profileXml{nullptr}; + IntegerAspect *m_maxCpu{nullptr}; + SelectionAspect *m_maxWinVer{nullptr}; + SelectionAspect *m_minWinVer{nullptr}; + StringAspect *m_title{nullptr}; + StringAspect *m_monFile{nullptr}; + BoolAspect *m_suppressStdOut{nullptr}; + StringAspect *m_logFile{nullptr}; + BoolAspect *m_showCmd{nullptr}; + BoolAspect *m_showAgents{nullptr}; + BoolAspect *m_showTime{nullptr}; + BoolAspect *m_hideHeader{nullptr}; + SelectionAspect *m_logLevel{nullptr}; + StringAspect *m_setEnv{nullptr}; + BoolAspect *m_stopOnError{nullptr}; + StringAspect *m_additionalArguments{nullptr}; + BoolAspect *m_openMonitor{nullptr}; + BoolAspect *m_keepJobNum{nullptr}; }; BuildConsoleBuildStep::BuildConsoleBuildStep(BuildStepList *buildStepList, Id id) @@ -117,7 +117,7 @@ BuildConsoleBuildStep::BuildConsoleBuildStep(BuildStepList *buildStepList, Id id "parameter value is large enough " "(such as -j200 for the JOM or Make build tools)")); - m_keepJobNum = addAspect(); + m_keepJobNum = addAspect(); m_keepJobNum->setSettingsKey(Constants::BUILDCONSOLE_KEEPJOBNUM); m_keepJobNum->setLabel(tr("Keep Original Jobs Num:")); m_keepJobNum->setToolTip(tr("Setting this option to true, forces IncrediBuild to not override " @@ -129,10 +129,10 @@ BuildConsoleBuildStep::BuildConsoleBuildStep(BuildStepList *buildStepList, Id id addAspect("" + tr("IncrediBuild Distribution Control")); - m_profileXml = addAspect(); + m_profileXml = addAspect(); m_profileXml->setSettingsKey(Constants::BUILDCONSOLE_PROFILEXML); m_profileXml->setLabelText(tr("Profile.xml:")); - m_profileXml->setDisplayStyle(BaseStringAspect::PathChooserDisplay); + m_profileXml->setDisplayStyle(StringAspect::PathChooserDisplay); m_profileXml->setExpectedKind(PathChooser::Kind::File); m_profileXml->setBaseFileName(FilePath::fromString(PathChooser::homePath())); m_profileXml->setHistoryCompleter("IncrediBuild.BuildConsole.ProfileXml.History"); @@ -145,7 +145,7 @@ BuildConsoleBuildStep::BuildConsoleBuildStep(BuildStepList *buildStepList, Id id "those packages. It is required to configure distributable " "processes in \"Dev Tools\" builds.")); - m_avoidLocal = addAspect(); + m_avoidLocal = addAspect(); m_avoidLocal->setSettingsKey(Constants::BUILDCONSOLE_AVOIDLOCAL); m_avoidLocal->setLabel(tr("Avoid Local:")); m_avoidLocal->setToolTip(tr("Overrides the Agent Settings dialog Avoid task execution on local " @@ -154,7 +154,7 @@ BuildConsoleBuildStep::BuildConsoleBuildStep(BuildStepList *buildStepList, Id id "in scenarios where the initiating machine is bottlenecking the " "build with High CPU usage.")); - m_maxCpu = addAspect(); + m_maxCpu = addAspect(); m_maxCpu->setSettingsKey(Constants::BUILDCONSOLE_MAXCPU); m_maxCpu->setToolTip(tr("Determines the maximum number of CPU cores that can be used in a " "build, regardless of the number of available Agents. " @@ -163,19 +163,19 @@ BuildConsoleBuildStep::BuildConsoleBuildStep(BuildStepList *buildStepList, Id id m_maxCpu->setLabel(tr("Maximum CPUs to utilize in the build:")); m_maxCpu->setRange(0, 65536); - m_maxWinVer = addAspect(); + m_maxWinVer = addAspect(); m_maxWinVer->setSettingsKey(Constants::BUILDCONSOLE_MAXWINVER); m_maxWinVer->setDisplayName(tr("Newest allowed helper machine OS:")); - m_maxWinVer->setDisplayStyle(BaseSelectionAspect::DisplayStyle::ComboBox); + m_maxWinVer->setDisplayStyle(SelectionAspect::DisplayStyle::ComboBox); m_maxWinVer->setToolTip(tr("Specifies the newest operating system installed on a helper " "machine to be allowed to participate as helper in the build.")); for (const QString &version : supportedWindowsVersions()) m_maxWinVer->addOption(version); - m_minWinVer = addAspect(); + m_minWinVer = addAspect(); m_minWinVer->setSettingsKey(Constants::BUILDCONSOLE_MINWINVER); m_minWinVer->setDisplayName(tr("Oldest allowed helper machine OS:")); - m_minWinVer->setDisplayStyle(BaseSelectionAspect::DisplayStyle::ComboBox); + m_minWinVer->setDisplayStyle(SelectionAspect::DisplayStyle::ComboBox); m_minWinVer->setToolTip(tr("Specifies the oldest operating system installed on a helper " "machine to be allowed to participate as helper in the build.")); for (const QString &version : supportedWindowsVersions()) @@ -183,18 +183,18 @@ BuildConsoleBuildStep::BuildConsoleBuildStep(BuildStepList *buildStepList, Id id addAspect("" + tr("Output and Logging")); - m_title = addAspect(); + m_title = addAspect(); m_title->setSettingsKey(Constants::BUILDCONSOLE_TITLE); m_title->setLabelText(tr("Build Title:")); - m_title->setDisplayStyle(BaseStringAspect::LineEditDisplay); + m_title->setDisplayStyle(StringAspect::LineEditDisplay); m_title->setToolTip(tr("Specifies a custom header line which will be displayed in the " "beginning of the build output text. This title will also be used " "for the Build History and Build Monitor displays.")); - m_monFile = addAspect(); + m_monFile = addAspect(); m_monFile->setSettingsKey(Constants::BUILDCONSOLE_MONFILE); m_monFile->setLabelText(tr("Save IncrediBuild monitor file:")); - m_monFile->setDisplayStyle(BaseStringAspect::PathChooserDisplay); + m_monFile->setDisplayStyle(StringAspect::PathChooserDisplay); m_monFile->setExpectedKind(PathChooser::Kind::Any); m_monFile->setBaseFileName(FilePath::fromString(PathChooser::homePath())); m_monFile->setHistoryCompleter(QLatin1String("IncrediBuild.BuildConsole.MonFile.History")); @@ -203,45 +203,45 @@ BuildConsoleBuildStep::BuildConsoleBuildStep(BuildStepList *buildStepList, Id id "GUID for the file name. - A message containing the location of the " "saved .ib_mon file is added to the end of the build output")); - m_suppressStdOut = addAspect(); + m_suppressStdOut = addAspect(); m_suppressStdOut->setSettingsKey(Constants::BUILDCONSOLE_SUPPRESSSTDOUT); m_suppressStdOut->setLabel(tr("Suppress STDOUT:")); m_suppressStdOut->setToolTip(tr("Does not write anything to the standard output.")); - m_logFile = addAspect(); + m_logFile = addAspect(); m_logFile->setSettingsKey(Constants::BUILDCONSOLE_LOGFILE); m_logFile->setLabelText(tr("Output Log file:")); - m_logFile->setDisplayStyle(BaseStringAspect::PathChooserDisplay); + m_logFile->setDisplayStyle(StringAspect::PathChooserDisplay); m_logFile->setExpectedKind(PathChooser::Kind::SaveFile); m_logFile->setBaseFileName(FilePath::fromString(PathChooser::homePath())); m_logFile->setHistoryCompleter(QLatin1String("IncrediBuild.BuildConsole.LogFile.History")); m_logFile->setToolTip(tr("Writes build output to a file.")); - m_showCmd = addAspect(); + m_showCmd = addAspect(); m_showCmd->setSettingsKey(Constants::BUILDCONSOLE_SHOWCMD); m_showCmd->setLabel(tr("Show Commands in output:")); m_showCmd->setToolTip(tr("Shows, for each file built, the command-line used by IncrediBuild " "to build the file.")); - m_showAgents = addAspect(); + m_showAgents = addAspect(); m_showAgents->setSettingsKey(Constants::BUILDCONSOLE_SHOWAGENTS); m_showAgents->setLabel(tr("Show Agents in output:")); m_showAgents->setToolTip(tr("Shows the Agent used to build each file.")); - m_showTime = addAspect(); + m_showTime = addAspect(); m_showTime->setSettingsKey(Constants::BUILDCONSOLE_SHOWTIME); m_showTime->setLabel(tr("Show Time in output:")); m_showTime->setToolTip(tr("Shows the Start and Finish time for each file built.")); - m_hideHeader = addAspect(); + m_hideHeader = addAspect(); m_hideHeader->setSettingsKey(Constants::BUILDCONSOLE_HIDEHEADER); m_hideHeader->setLabel(tr("Hide IncrediBuild Header in output:")); m_hideHeader->setToolTip(tr("Suppresses the \"IncrediBuild\" header in the build output")); - m_logLevel = addAspect(); + m_logLevel = addAspect(); m_logLevel->setSettingsKey(Constants::BUILDCONSOLE_LOGLEVEL); m_logLevel->setDisplayName(tr("Internal IncrediBuild logging level:")); - m_logLevel->setDisplayStyle(BaseSelectionAspect::DisplayStyle::ComboBox); + m_logLevel->setDisplayStyle(SelectionAspect::DisplayStyle::ComboBox); m_logLevel->addOption(QString()); m_logLevel->addOption("Minimal"); m_logLevel->addOption("Extended"); @@ -252,13 +252,13 @@ BuildConsoleBuildStep::BuildConsoleBuildStep(BuildStepList *buildStepList, Id id addAspect("" + tr("Miscellaneous")); - m_setEnv = addAspect(); + m_setEnv = addAspect(); m_setEnv->setSettingsKey(Constants::BUILDCONSOLE_SETENV); m_setEnv->setLabelText(tr("Set an Environment Variable:")); - m_setEnv->setDisplayStyle(BaseStringAspect::LineEditDisplay); + m_setEnv->setDisplayStyle(StringAspect::LineEditDisplay); m_setEnv->setToolTip(tr("Sets or overrides environment variables for the context of the build.")); - m_stopOnError = addAspect(); + m_stopOnError = addAspect(); m_stopOnError->setSettingsKey(Constants::BUILDCONSOLE_STOPONERROR); m_stopOnError->setLabel(tr("Stop On Errors:")); m_stopOnError->setToolTip(tr("When specified, the execution will stop as soon as an error " @@ -266,16 +266,16 @@ BuildConsoleBuildStep::BuildConsoleBuildStep(BuildStepList *buildStepList, Id id "\"Visual Studio\" builds, but not the default for " "\"Make and Build tools\" or \"Dev Tools\" builds")); - m_additionalArguments = addAspect(); + m_additionalArguments = addAspect(); m_additionalArguments->setSettingsKey(Constants::BUILDCONSOLE_ADDITIONALARGUMENTS); m_additionalArguments->setLabelText(tr("Additional Arguments:")); - m_additionalArguments->setDisplayStyle(BaseStringAspect::LineEditDisplay); + m_additionalArguments->setDisplayStyle(StringAspect::LineEditDisplay); m_additionalArguments->setToolTip(tr("Add additional buildconsole arguments manually. " "The value of this field will be concatenated to the " "final buildconsole command line")); - m_openMonitor = addAspect(); + m_openMonitor = addAspect(); m_openMonitor->setSettingsKey(Constants::BUILDCONSOLE_OPENMONITOR); m_openMonitor->setLabel(tr("Open Monitor:")); m_openMonitor->setToolTip(tr("Opens an IncrediBuild Build Monitor that graphically displays " diff --git a/src/plugins/incredibuild/ibconsolebuildstep.cpp b/src/plugins/incredibuild/ibconsolebuildstep.cpp index 39e6729cb65..6ef1610dc7f 100644 --- a/src/plugins/incredibuild/ibconsolebuildstep.cpp +++ b/src/plugins/incredibuild/ibconsolebuildstep.cpp @@ -62,10 +62,10 @@ public: private: CommandBuilderAspect *m_commandBuilder; - BaseIntegerAspect *m_nice{nullptr}; - BaseBoolAspect *m_keepJobNum{nullptr}; - BaseBoolAspect *m_forceRemote{nullptr}; - BaseBoolAspect *m_alternate{nullptr}; + IntegerAspect *m_nice{nullptr}; + BoolAspect *m_keepJobNum{nullptr}; + BoolAspect *m_forceRemote{nullptr}; + BoolAspect *m_alternate{nullptr}; }; IBConsoleBuildStep::IBConsoleBuildStep(BuildStepList *buildStepList, Id id) @@ -83,7 +83,7 @@ IBConsoleBuildStep::IBConsoleBuildStep(BuildStepList *buildStepList, Id id) "multi-job parameter value is large enough (such as " "-j200 for the JOM or Make build tools)")); - m_keepJobNum = addAspect(); + m_keepJobNum = addAspect(); m_keepJobNum->setSettingsKey(Constants::IBCONSOLE_KEEPJOBNUM); m_keepJobNum->setLabel(tr("Keep Original Jobs Num:")); m_keepJobNum->setToolTip(tr("Setting this option to true, forces IncrediBuild to not override " @@ -95,17 +95,17 @@ IBConsoleBuildStep::IBConsoleBuildStep(BuildStepList *buildStepList, Id id) addAspect("" + tr("IncrediBuild Distribution Control")); - m_nice = addAspect(); + m_nice = addAspect(); m_nice->setSettingsKey(Constants::IBCONSOLE_NICE); m_nice->setToolTip(tr("Specify nice value. Nice Value should be numeric and between -20 and 19")); m_nice->setLabel(tr("Nice value:")); m_nice->setRange(-20, 19); - m_forceRemote = addAspect(); + m_forceRemote = addAspect(); m_forceRemote->setSettingsKey(Constants::IBCONSOLE_ALTERNATE); m_forceRemote->setLabel(tr("Force remote:")); - m_alternate = addAspect(); + m_alternate = addAspect(); m_alternate->setSettingsKey(Constants::IBCONSOLE_FORCEREMOTE); m_alternate->setLabel(tr("Alternate tasks preference:")); } diff --git a/src/plugins/ios/iosbuildconfiguration.cpp b/src/plugins/ios/iosbuildconfiguration.cpp index 5cb7742c31c..1d45d806670 100644 --- a/src/plugins/ios/iosbuildconfiguration.cpp +++ b/src/plugins/ios/iosbuildconfiguration.cpp @@ -379,10 +379,10 @@ void IosBuildSettingsWidget::updateWarningText() IosBuildConfiguration::IosBuildConfiguration(Target *target, Utils::Id id) : QmakeBuildConfiguration(target, id) { - m_signingIdentifier = addAspect(); + m_signingIdentifier = addAspect(); m_signingIdentifier->setSettingsKey(signingIdentifierKey); - m_autoManagedSigning = addAspect(); + m_autoManagedSigning = addAspect(); m_autoManagedSigning->setDefaultValue(true); m_autoManagedSigning->setSettingsKey(autoManagedSigningKey); } diff --git a/src/plugins/ios/iosbuildconfiguration.h b/src/plugins/ios/iosbuildconfiguration.h index 28804a57c29..51565c0ecdf 100644 --- a/src/plugins/ios/iosbuildconfiguration.h +++ b/src/plugins/ios/iosbuildconfiguration.h @@ -46,8 +46,8 @@ private: void updateQmakeCommand(); - ProjectExplorer::BaseStringAspect *m_signingIdentifier = nullptr; - ProjectExplorer::BaseBoolAspect *m_autoManagedSigning = nullptr; + ProjectExplorer::StringAspect *m_signingIdentifier = nullptr; + ProjectExplorer::BoolAspect *m_autoManagedSigning = nullptr; }; class IosBuildConfigurationFactory : public QmakeProjectManager::QmakeBuildConfigurationFactory diff --git a/src/plugins/ios/iosrunconfiguration.cpp b/src/plugins/ios/iosrunconfiguration.cpp index cdcbff90b6d..83b46f6e528 100644 --- a/src/plugins/ios/iosrunconfiguration.cpp +++ b/src/plugins/ios/iosrunconfiguration.cpp @@ -106,7 +106,7 @@ IosRunConfiguration::IosRunConfiguration(Target *target, Utils::Id id) : RunConfiguration(target, id) { auto executableAspect = addAspect(); - executableAspect->setDisplayStyle(BaseStringAspect::LabelDisplay); + executableAspect->setDisplayStyle(StringAspect::LabelDisplay); addAspect(); diff --git a/src/plugins/mcusupport/mcusupportrunconfiguration.cpp b/src/plugins/mcusupport/mcusupportrunconfiguration.cpp index 63676469b8d..ee325a2d78c 100644 --- a/src/plugins/mcusupport/mcusupportrunconfiguration.cpp +++ b/src/plugins/mcusupport/mcusupportrunconfiguration.cpp @@ -67,9 +67,9 @@ public: FlashAndRunConfiguration(Target *target, Utils::Id id) : RunConfiguration(target, id) { - auto flashAndRunParameters = addAspect(); + auto flashAndRunParameters = addAspect(); flashAndRunParameters->setLabelText(tr("Flash and run CMake parameters:")); - flashAndRunParameters->setDisplayStyle(BaseStringAspect::TextEditDisplay); + flashAndRunParameters->setDisplayStyle(StringAspect::TextEditDisplay); flashAndRunParameters->setSettingsKey("FlashAndRunConfiguration.Parameters"); setUpdater([target, flashAndRunParameters] { @@ -92,7 +92,7 @@ public: const Target *target = runControl->target(); const CommandLine cmd( cmakeFilePath(target), - runControl->runConfiguration()->aspect()->value(), + runControl->runConfiguration()->aspect()->value(), CommandLine::Raw); Runnable r; r.workingDirectory = diff --git a/src/plugins/nim/project/nimcompilercleanstep.cpp b/src/plugins/nim/project/nimcompilercleanstep.cpp index ca5626776a6..4d37fddc2b8 100644 --- a/src/plugins/nim/project/nimcompilercleanstep.cpp +++ b/src/plugins/nim/project/nimcompilercleanstep.cpp @@ -64,9 +64,9 @@ NimCompilerCleanStep::NimCompilerCleanStep(BuildStepList *parentList, Utils::Id setDefaultDisplayName(tr("Nim Clean Step")); setDisplayName(tr("Nim Clean Step")); - auto workingDirectory = addAspect(); + auto workingDirectory = addAspect(); workingDirectory->setLabelText(tr("Working directory:")); - workingDirectory->setDisplayStyle(BaseStringAspect::LineEditDisplay); + workingDirectory->setDisplayStyle(StringAspect::LineEditDisplay); setSummaryUpdater([this, workingDirectory] { workingDirectory->setFilePath(buildDirectory()); diff --git a/src/plugins/projectexplorer/buildaspects.cpp b/src/plugins/projectexplorer/buildaspects.cpp index 0d8a3c3bc8b..a061605ef48 100644 --- a/src/plugins/projectexplorer/buildaspects.cpp +++ b/src/plugins/projectexplorer/buildaspects.cpp @@ -79,7 +79,7 @@ void BuildDirectoryAspect::setProblem(const QString &description) void BuildDirectoryAspect::toMap(QVariantMap &map) const { - BaseStringAspect::toMap(map); + StringAspect::toMap(map); if (!d->sourceDir.isEmpty()) { const FilePath shadowDir = isChecked() ? filePath() : d->savedShadowBuildDir; map.insert(settingsKey() + ".shadowDir", shadowDir.toString()); @@ -88,7 +88,7 @@ void BuildDirectoryAspect::toMap(QVariantMap &map) const void BuildDirectoryAspect::fromMap(const QVariantMap &map) { - BaseStringAspect::fromMap(map); + StringAspect::fromMap(map); if (!d->sourceDir.isEmpty()) { d->savedShadowBuildDir = FilePath::fromString(map.value(settingsKey() + ".shadowDir") .toString()); @@ -98,13 +98,13 @@ void BuildDirectoryAspect::fromMap(const QVariantMap &map) void BuildDirectoryAspect::addToLayout(LayoutBuilder &builder) { - BaseStringAspect::addToLayout(builder); + StringAspect::addToLayout(builder); d->problemLabel = new InfoLabel({}, InfoLabel::Warning); d->problemLabel->setElideMode(Qt::ElideNone); builder.startNewRow().addItems(QString(), d->problemLabel.data()); updateProblemLabel(); if (!d->sourceDir.isEmpty()) { - connect(this, &BaseStringAspect::checkedChanged, builder.layout(), [this] { + connect(this, &StringAspect::checkedChanged, builder.layout(), [this] { if (isChecked()) { setFilePath(d->savedShadowBuildDir.isEmpty() ? d->sourceDir : d->savedShadowBuildDir); diff --git a/src/plugins/projectexplorer/buildaspects.h b/src/plugins/projectexplorer/buildaspects.h index 2933b5447f9..f34e3d732a3 100644 --- a/src/plugins/projectexplorer/buildaspects.h +++ b/src/plugins/projectexplorer/buildaspects.h @@ -32,7 +32,7 @@ namespace Utils { class FilePath; } namespace ProjectExplorer { -class PROJECTEXPLORER_EXPORT BuildDirectoryAspect : public BaseStringAspect +class PROJECTEXPLORER_EXPORT BuildDirectoryAspect : public StringAspect { Q_OBJECT public: @@ -55,7 +55,7 @@ private: Private * const d; }; -class PROJECTEXPLORER_EXPORT SeparateDebugInfoAspect : public BaseTriStateAspect +class PROJECTEXPLORER_EXPORT SeparateDebugInfoAspect : public TriStateAspect { Q_OBJECT public: diff --git a/src/plugins/projectexplorer/buildconfiguration.cpp b/src/plugins/projectexplorer/buildconfiguration.cpp index 0e3a30427c7..7c864360352 100644 --- a/src/plugins/projectexplorer/buildconfiguration.cpp +++ b/src/plugins/projectexplorer/buildconfiguration.cpp @@ -193,7 +193,7 @@ BuildConfiguration::BuildConfiguration(Target *target, Utils::Id id) d->m_buildDirectoryAspect->setBaseFileName(target->project()->projectDirectory()); d->m_buildDirectoryAspect->setEnvironment(environment()); d->m_buildDirectoryAspect->setMacroExpanderProvider([this] { return macroExpander(); }); - connect(d->m_buildDirectoryAspect, &BaseStringAspect::changed, + connect(d->m_buildDirectoryAspect, &StringAspect::changed, this, &BuildConfiguration::emitBuildDirectoryChanged); connect(this, &BuildConfiguration::environmentChanged, this, [this] { d->m_buildDirectoryAspect->setEnvironment(environment()); diff --git a/src/plugins/projectexplorer/customexecutablerunconfiguration.cpp b/src/plugins/projectexplorer/customexecutablerunconfiguration.cpp index 95c8760ad04..5b502feb8c8 100644 --- a/src/plugins/projectexplorer/customexecutablerunconfiguration.cpp +++ b/src/plugins/projectexplorer/customexecutablerunconfiguration.cpp @@ -70,7 +70,7 @@ CustomExecutableRunConfiguration::CustomExecutableRunConfiguration(Target *targe auto exeAspect = addAspect(); exeAspect->setSettingsKey("ProjectExplorer.CustomExecutableRunConfiguration.Executable"); - exeAspect->setDisplayStyle(BaseStringAspect::PathChooserDisplay); + exeAspect->setDisplayStyle(StringAspect::PathChooserDisplay); exeAspect->setHistoryCompleter("Qt.CustomExecutable.History"); exeAspect->setExpectedKind(PathChooser::ExistingCommand); exeAspect->setEnvironment(envAspect->environment()); diff --git a/src/plugins/projectexplorer/makestep.cpp b/src/plugins/projectexplorer/makestep.cpp index 23eb063d6f5..6013bc7f0f3 100644 --- a/src/plugins/projectexplorer/makestep.cpp +++ b/src/plugins/projectexplorer/makestep.cpp @@ -67,7 +67,7 @@ const char MAKEFLAGS[] = "MAKEFLAGS"; namespace ProjectExplorer { namespace Internal { -class OverrideMakeflagsAspect final : public BaseBoolAspect +class OverrideMakeflagsAspect final : public BoolAspect { public: OverrideMakeflagsAspect() {} @@ -90,7 +90,7 @@ public: m_nonOverrideWarning->setPixmap(Icons::WARNING.pixmap()); } - BaseBoolAspect::addToLayout(builder); + BoolAspect::addToLayout(builder); builder.addItem(m_nonOverrideWarning.data()); } @@ -162,19 +162,19 @@ MakeStep::MakeStep(BuildStepList *parent, Utils::Id id) setDefaultDisplayName(defaultDisplayName()); setLowPriority(); - m_makeCommandAspect = addAspect(); + m_makeCommandAspect = addAspect(); m_makeCommandAspect->setSettingsKey(id.withSuffix(MAKE_COMMAND_SUFFIX).toString()); - m_makeCommandAspect->setDisplayStyle(BaseStringAspect::PathChooserDisplay); + m_makeCommandAspect->setDisplayStyle(StringAspect::PathChooserDisplay); m_makeCommandAspect->setExpectedKind(PathChooser::ExistingCommand); m_makeCommandAspect->setBaseFileName(FilePath::fromString(PathChooser::homePath())); m_makeCommandAspect->setHistoryCompleter("PE.MakeCommand.History"); - m_userArgumentsAspect = addAspect(); + m_userArgumentsAspect = addAspect(); m_userArgumentsAspect->setSettingsKey(id.withSuffix(MAKE_ARGUMENTS_SUFFIX).toString()); m_userArgumentsAspect->setLabelText(tr("Make arguments:")); - m_userArgumentsAspect->setDisplayStyle(BaseStringAspect::LineEditDisplay); + m_userArgumentsAspect->setDisplayStyle(StringAspect::LineEditDisplay); - m_userJobCountAspect = addAspect(); + m_userJobCountAspect = addAspect(); m_userJobCountAspect->setSettingsKey(id.withSuffix(JOBCOUNT_SUFFIX).toString()); m_userJobCountAspect->setLabel(tr("Parallel jobs:")); m_userJobCountAspect->setRange(1, 999); @@ -184,10 +184,10 @@ MakeStep::MakeStep(BuildStepList *parent, Utils::Id id) m_overrideMakeflagsAspect = addAspect(); m_overrideMakeflagsAspect->setSettingsKey(id.withSuffix(OVERRIDE_MAKEFLAGS_SUFFIX).toString()); - m_cleanAspect = addAspect(); + m_cleanAspect = addAspect(); m_cleanAspect->setSettingsKey(id.withSuffix(CLEAN_SUFFIX).toString()); - m_buildTargetsAspect = addAspect(); + m_buildTargetsAspect = addAspect(); m_buildTargetsAspect->setSettingsKey(id.withSuffix(BUILD_TARGETS_SUFFIX).toString()); const auto updateMakeLabel = [this] { @@ -200,7 +200,7 @@ MakeStep::MakeStep(BuildStepList *parent, Utils::Id id) updateMakeLabel(); - connect(m_makeCommandAspect, &BaseStringAspect::changed, this, updateMakeLabel); + connect(m_makeCommandAspect, &StringAspect::changed, this, updateMakeLabel); } void MakeStep::setBuildTarget(const QString &buildTarget) @@ -486,10 +486,10 @@ BuildStepConfigWidget *MakeStep::createConfigWidget() updateDetails(); - connect(m_makeCommandAspect, &BaseStringAspect::changed, widget, updateDetails); - connect(m_userArgumentsAspect, &BaseStringAspect::changed, widget, updateDetails); - connect(m_userJobCountAspect, &BaseIntegerAspect::changed, widget, updateDetails); - connect(m_overrideMakeflagsAspect, &BaseBoolAspect::changed, widget, updateDetails); + connect(m_makeCommandAspect, &StringAspect::changed, widget, updateDetails); + connect(m_userArgumentsAspect, &StringAspect::changed, widget, updateDetails); + connect(m_userJobCountAspect, &IntegerAspect::changed, widget, updateDetails); + connect(m_overrideMakeflagsAspect, &BoolAspect::changed, widget, updateDetails); connect(widget->m_targetsList, &QListWidget::itemChanged, this, [this, updateDetails](QListWidgetItem *item) { diff --git a/src/plugins/projectexplorer/makestep.h b/src/plugins/projectexplorer/makestep.h index 2d2d0a49e83..be04787f07e 100644 --- a/src/plugins/projectexplorer/makestep.h +++ b/src/plugins/projectexplorer/makestep.h @@ -38,10 +38,10 @@ class MakeStepConfigWidget; class OverrideMakeflagsAspect; } // Internal -class BaseBoolAspect; -class BaseIntegerAspect; -class BaseStringAspect; -class BaseStringListAspect; +class BoolAspect; +class IntegerAspect; +class StringAspect; +class StringListAspect; class PROJECTEXPLORER_EXPORT MakeStep : public ProjectExplorer::AbstractProcessStep { @@ -102,13 +102,13 @@ private: static int defaultJobCount(); QStringList jobArguments() const; - BaseStringListAspect *m_buildTargetsAspect = nullptr; + StringListAspect *m_buildTargetsAspect = nullptr; QStringList m_availableTargets; - BaseStringAspect *m_makeCommandAspect = nullptr; - BaseStringAspect *m_userArgumentsAspect = nullptr; - BaseIntegerAspect *m_userJobCountAspect = nullptr; + StringAspect *m_makeCommandAspect = nullptr; + StringAspect *m_userArgumentsAspect = nullptr; + IntegerAspect *m_userJobCountAspect = nullptr; Internal::OverrideMakeflagsAspect *m_overrideMakeflagsAspect = nullptr; - BaseBoolAspect *m_cleanAspect = nullptr; + BoolAspect *m_cleanAspect = nullptr; bool m_disablingForSubDirsSupported = false; bool m_enabledForSubDirs = true; }; diff --git a/src/plugins/projectexplorer/processstep.cpp b/src/plugins/projectexplorer/processstep.cpp index 08a784f28e1..50b6fc1e551 100644 --- a/src/plugins/projectexplorer/processstep.cpp +++ b/src/plugins/projectexplorer/processstep.cpp @@ -57,9 +57,9 @@ public: void setupOutputFormatter(Utils::OutputFormatter *formatter); void setupProcessParameters(ProcessParameters *pp); - BaseStringAspect *m_command; - BaseStringAspect *m_arguments; - BaseStringAspect *m_workingDirectory; + StringAspect *m_command; + StringAspect *m_arguments; + StringAspect *m_workingDirectory; }; ProcessStep::ProcessStep(BuildStepList *bsl, Utils::Id id) @@ -68,22 +68,22 @@ ProcessStep::ProcessStep(BuildStepList *bsl, Utils::Id id) //: Default ProcessStep display name setDefaultDisplayName(tr("Custom Process Step")); - m_command = addAspect(); + m_command = addAspect(); m_command->setSettingsKey(PROCESS_COMMAND_KEY); - m_command->setDisplayStyle(BaseStringAspect::PathChooserDisplay); + m_command->setDisplayStyle(StringAspect::PathChooserDisplay); m_command->setLabelText(tr("Command:")); m_command->setExpectedKind(Utils::PathChooser::Command); m_command->setHistoryCompleter("PE.ProcessStepCommand.History"); - m_arguments = addAspect(); + m_arguments = addAspect(); m_arguments->setSettingsKey(PROCESS_ARGUMENTS_KEY); - m_arguments->setDisplayStyle(BaseStringAspect::LineEditDisplay); + m_arguments->setDisplayStyle(StringAspect::LineEditDisplay); m_arguments->setLabelText(tr("Arguments:")); - m_workingDirectory = addAspect(); + m_workingDirectory = addAspect(); m_workingDirectory->setSettingsKey(PROCESS_WORKINGDIRECTORY_KEY); m_workingDirectory->setValue(Constants::DEFAULT_WORKING_DIR); - m_workingDirectory->setDisplayStyle(BaseStringAspect::PathChooserDisplay); + m_workingDirectory->setDisplayStyle(StringAspect::PathChooserDisplay); m_workingDirectory->setLabelText(tr("Working directory:")); m_workingDirectory->setExpectedKind(Utils::PathChooser::Directory); diff --git a/src/plugins/projectexplorer/projectconfigurationaspects.cpp b/src/plugins/projectexplorer/projectconfigurationaspects.cpp index 59d897dccd5..e1c44c86a46 100644 --- a/src/plugins/projectexplorer/projectconfigurationaspects.cpp +++ b/src/plugins/projectexplorer/projectconfigurationaspects.cpp @@ -54,10 +54,10 @@ using namespace Utils; namespace ProjectExplorer { namespace Internal { -class BaseBoolAspectPrivate +class BoolAspectPrivate { public: - BaseBoolAspect::LabelPlacement m_labelPlacement = BaseBoolAspect::LabelPlacement::AtCheckBox; + BoolAspect::LabelPlacement m_labelPlacement = BoolAspect::LabelPlacement::AtCheckBox; bool m_value = false; bool m_defaultValue = false; bool m_enabled = true; @@ -67,13 +67,13 @@ public: QPointer m_label; // Owned by configuration widget }; -class BaseSelectionAspectPrivate +class SelectionAspectPrivate { public: int m_value = 0; int m_defaultValue = 0; - BaseSelectionAspect::DisplayStyle m_displayStyle - = BaseSelectionAspect::DisplayStyle::RadioButtons; + SelectionAspect::DisplayStyle m_displayStyle + = SelectionAspect::DisplayStyle::RadioButtons; struct Option { QString displayName; QString tooltip; }; QVector