From 51edace4219293ac5a7b6fcf686606f3146088a7 Mon Sep 17 00:00:00 2001 From: Dmytro Poplavskiy Date: Mon, 22 Feb 2016 15:28:58 +1000 Subject: [PATCH] Fixed segfault in SshKeyExchange due to using object after deletion m_dhKey pointer has been used for debug output just after resetting it to nullptr. Change-Id: I1aa4e16b19c7a16738b7734423277cf7eecd8054 Reviewed-by: Eike Ziller Reviewed-by: Christian Kandeler --- src/libs/ssh/sshkeyexchange.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/ssh/sshkeyexchange.cpp b/src/libs/ssh/sshkeyexchange.cpp index ef48c8f05ff..cdcb45556c5 100644 --- a/src/libs/ssh/sshkeyexchange.cpp +++ b/src/libs/ssh/sshkeyexchange.cpp @@ -154,9 +154,9 @@ void SshKeyExchange::sendNewKeysPacket(const SshIncomingPacket &dhReply, DH_KA_Operation dhOp(*m_dhKey); SecureVector encodedF = BigInt::encode(reply.f); encodedK = dhOp.agree(encodedF, encodedF.size()); - m_dhKey.reset(nullptr); printData("y", AbstractSshPacket::encodeMpInt(m_dhKey->get_y())); printData("f", AbstractSshPacket::encodeMpInt(reply.f)); + m_dhKey.reset(nullptr); } else { Q_ASSERT(m_ecdhKey); concatenatedData // Q_C.