feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Re-organize KitAspect layouting related functions

Browse Source 
Less obscure as it's fairly close to the standard pattern now.

Change-Id: I4680465fbdb9fb6a458c18ef0534e4d8a4a31d1e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2023-08-22 09:54:38 +02:00
parent 0667bdaedc
commit 5254765e16
12 changed files with 29 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/cmakeprojectmanager/cmakebuildconfiguration.cpp
View File

@@ -651,13 +651,13 @@ void CMakeBuildSettingsWidget::kitCMakeConfiguration()
Layouting::Grid grid;
KitAspect *widget = CMakeKitAspect::createKitAspect(m_buildConfig->kit());
widget->setParent(dialog);
widget->addToLayoutWithLabel(grid);
widget->addToLayout(grid);
widget = CMakeGeneratorKitAspect::createKitAspect(m_buildConfig->kit());
widget->setParent(dialog);
widget->addToLayoutWithLabel(grid);
widget->addToLayout(grid);
widget = CMakeConfigurationKitAspect::createKitAspect(m_buildConfig->kit());
widget->setParent(dialog);
widget->addToLayoutWithLabel(grid);
widget->addToLayout(grid);
grid.attachTo(dialog);
auto layout = qobject_cast<QGridLayout *>(dialog->layout());

6
src/plugins/cmakeprojectmanager/cmakekitaspect.cpp
View File

@@ -149,7 +149,7 @@ private:
// KitAspectWidget interface
void makeReadOnly() override { m_comboBox->setEnabled(false); }
void addToLayout(Layouting::LayoutItem &builder) override
void addToLayoutImpl(Layouting::LayoutItem &builder) override
{
addMutableAction(m_comboBox);
builder.addItem(m_comboBox);
@@ -373,7 +373,7 @@ private:
// KitAspectWidget interface
void makeReadOnly() override { m_changeButton->setEnabled(false); }
void addToLayout(Layouting::LayoutItem &parent) override
void addToLayoutImpl(Layouting::LayoutItem &parent) override
{
addMutableAction(m_label);
parent.addItem(m_label);
@@ -912,7 +912,7 @@ public:
private:
// KitAspectWidget interface
void addToLayout(Layouting::LayoutItem &parent) override
void addToLayoutImpl(Layouting::LayoutItem &parent) override
{
addMutableAction(m_summaryLabel);
parent.addItem(m_summaryLabel);