From 525d26db03cbb46ed35d0d8e1544e8708b4b4214 Mon Sep 17 00:00:00 2001 From: David Schulz Date: Fri, 11 Mar 2022 14:07:03 +0100 Subject: [PATCH] Editor: centralize annotation filtering Change-Id: I68464b14b44beee772ace93f7bdebc32ae3325ef Reviewed-by: Christian Stenger --- src/plugins/texteditor/texteditor.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/plugins/texteditor/texteditor.cpp b/src/plugins/texteditor/texteditor.cpp index d81e9ae9397..27e2bc36b92 100644 --- a/src/plugins/texteditor/texteditor.cpp +++ b/src/plugins/texteditor/texteditor.cpp @@ -3970,7 +3970,7 @@ void TextEditorWidgetPrivate::updateLineAnnotation(const PaintEventData &data, return; TextMarks marks = Utils::filtered(blockUserData->marks(), [](const TextMark* mark){ - return !mark->lineAnnotation().isEmpty(); + return !mark->lineAnnotation().isEmpty() && mark->isVisible(); }); const bool annotationsVisible = !marks.isEmpty(); @@ -4015,8 +4015,6 @@ void TextEditorWidgetPrivate::updateLineAnnotation(const PaintEventData &data, } for (const TextMark *mark : qAsConst(marks)) { - if (!mark->isVisible()) - continue; boundingRect = QRectF(x, boundingRect.top(), q->viewport()->width() - x, boundingRect.height()); if (boundingRect.isEmpty()) break;