From 525d833cdbd66c09294b0061d962d1c81d6ddd00 Mon Sep 17 00:00:00 2001
From: Christian Kandeler <christian.kandeler@qt.io>
Date: Mon, 30 Sep 2024 14:10:18 +0200
Subject: [PATCH] Debugger: Make icons and tooltips consistent in options page

Change-Id: Ib64e5d359253c02541e2f5b58561340ef8a49cfe
Reviewed-by: hjk <hjk@qt.io>
---
 src/plugins/debugger/debuggeritem.cpp | 34 ++++++++++++++++++++++-----
 src/plugins/debugger/debuggeritem.h   |  2 ++
 2 files changed, 30 insertions(+), 6 deletions(-)

diff --git a/src/plugins/debugger/debuggeritem.cpp b/src/plugins/debugger/debuggeritem.cpp
index dfa45da6d9b..6709bb4c55c 100644
--- a/src/plugins/debugger/debuggeritem.cpp
+++ b/src/plugins/debugger/debuggeritem.cpp
@@ -306,24 +306,46 @@ QDateTime DebuggerItem::lastModified() const
     return m_lastModified;
 }
 
-QIcon DebuggerItem::decoration() const
+DebuggerItem::Problem DebuggerItem::problem() const
 {
     if (isGeneric())
-        return {};
+        return Problem::None;
     if (m_engineType == NoEngineType)
-        return Icons::CRITICAL.icon();
+        return Problem::NoEngine;
     if (!m_command.isExecutableFile())
-        return Icons::WARNING.icon();
+        return Problem::InvalidCommand;
     if (!m_workingDirectory.isEmpty() && !m_workingDirectory.isDir())
+        return Problem::InvalidWorkingDir;
+    return Problem::None;
+}
+
+QIcon DebuggerItem::decoration() const
+{
+    switch (problem()) {
+    case Problem::NoEngine:
+        return Icons::CRITICAL.icon();
+    case Problem::InvalidCommand:
+    case Problem::InvalidWorkingDir:
         return Icons::WARNING.icon();
+    case Problem::None:
+        break;
+    }
     return {};
 }
 
 QString DebuggerItem::validityMessage() const
 {
-    if (m_engineType == NoEngineType)
+    switch (problem()) {
+    case Problem::NoEngine:
         return Tr::tr("Could not determine debugger type");
-    return QString();
+    case Problem::InvalidCommand:
+        return Tr::tr("Invalid debugger command");
+    case Problem::InvalidWorkingDir:
+        return Tr::tr("Invalid working directory");
+    case Problem::None:
+        break;
+    }
+    return {};
 }
 
 bool DebuggerItem::operator==(const DebuggerItem &other) const
diff --git a/src/plugins/debugger/debuggeritem.h b/src/plugins/debugger/debuggeritem.h
index dcdd80ad7ce..96e3cf4cc57 100644
--- a/src/plugins/debugger/debuggeritem.h
+++ b/src/plugins/debugger/debuggeritem.h
@@ -67,6 +67,8 @@ public:
     QStringList abiNames() const;
     QDateTime lastModified() const;
 
+    enum class Problem { NoEngine, InvalidCommand, InvalidWorkingDir, None };
+    Problem problem() const;
     QIcon decoration() const;
     QString validityMessage() const;