feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlProfiler: Make members of QmlNote private

Browse Source 
The only member that can change after initialization is the text.

Change-Id: I6958f510e67c9fd6fe1f109c2676f80d93e7fd0c
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
This commit is contained in:
Ulf Hermann
2016-06-07 13:54:23 +02:00
parent 0c0cb4b043
commit 52ee1141a8
4 changed files with 30 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/plugins/qmlprofiler/qmlprofilertracefile.cpp
View File

@@ -525,14 +525,14 @@ void QmlProfilerFileReader::loadNotes(QXmlStreamReader &stream)
if (elementName == _("note")) {
updateProgress(stream.device());
QXmlStreamAttributes attrs = stream.attributes();
currentNote.startTime = attrs.value(_("startTime")).toLongLong();
currentNote.duration = attrs.value(_("duration")).toLongLong();
currentNote.typeIndex = attrs.value(_("eventIndex")).toInt();
currentNote = QmlNote(attrs.value(_("eventIndex")).toInt(),
attrs.value(_("startTime")).toLongLong(),
attrs.value(_("duration")).toLongLong());
}
break;
}
case QXmlStreamReader::Characters: {
currentNote.text = stream.text().toString();
currentNote.setText(stream.text().toString());
break;
}
case QXmlStreamReader::EndElement: {
@@ -747,10 +747,10 @@ void QmlProfilerFileWriter::saveQtd(QIODevice *device)
const QmlNote &note = m_notes[noteIndex];
stream.writeStartElement(_("note"));
stream.writeAttribute(_("startTime"), QString::number(note.startTime));
stream.writeAttribute(_("duration"), QString::number(note.duration));
stream.writeAttribute(_("eventIndex"), QString::number(note.typeIndex));
stream.writeCharacters(note.text);
stream.writeAttribute(_("startTime"), QString::number(note.startTime()));
stream.writeAttribute(_("duration"), QString::number(note.duration()));
stream.writeAttribute(_("eventIndex"), QString::number(note.typeIndex()));
stream.writeCharacters(note.text());
stream.writeEndElement(); // note
incrementProgress();
}