feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

PerfProfiler: Remove warnings

Browse Source 
Remove warnings about unused arguments and [this] lambda captures.

Change-Id: Ic1ab0808008cf628a9114d4fcc7c38890f33d4dd
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2023-11-21 18:17:47 +01:00
parent 6b7d250744
commit 530119c2e3
5 changed files with 6 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/perfprofiler/perfprofilerflamegraphview.cpp
View File

@@ -3,8 +3,6 @@
#include "perfprofilerflamegraphmodel.h" #include "perfprofilerflamegraphmodel.h"
#include "perfprofilerflamegraphview.h" #include "perfprofilerflamegraphview.h"
#include "perfprofilertool.h"
#include "perftimelinemodel.h"
#include <tracing/flamegraph.h> #include <tracing/flamegraph.h>
#include <tracing/timelinetheme.h> #include <tracing/timelinetheme.h>
@@ -16,8 +14,8 @@
namespace PerfProfiler { namespace PerfProfiler {
namespace Internal { namespace Internal {
PerfProfilerFlameGraphView::PerfProfilerFlameGraphView(QWidget *parent, PerfProfilerTool *tool) : PerfProfilerFlameGraphView::PerfProfilerFlameGraphView(QWidget *parent)
QQuickWidget(parent) : QQuickWidget(parent)
{ {
setObjectName(QLatin1String("PerfProfilerFlameGraphView")); setObjectName(QLatin1String("PerfProfilerFlameGraphView"));

2
src/plugins/perfprofiler/perfprofilerflamegraphview.h
View File

@@ -15,7 +15,7 @@ class PerfProfilerFlameGraphView : public QQuickWidget
{ {
Q_OBJECT Q_OBJECT
public: public:
PerfProfilerFlameGraphView(QWidget *parent, PerfProfilerTool *tool); PerfProfilerFlameGraphView(QWidget *parent);
~PerfProfilerFlameGraphView(); ~PerfProfilerFlameGraphView();
void selectByTypeId(int typeId); void selectByTypeId(int typeId);

1
src/plugins/perfprofiler/perfprofilerstatisticsview.cpp
View File

@@ -3,7 +3,6 @@
#include "perfprofilerstatisticsmodel.h" #include "perfprofilerstatisticsmodel.h"
#include "perfprofilerstatisticsview.h" #include "perfprofilerstatisticsview.h"
#include "perfprofilertool.h"
#include <coreplugin/minisplitter.h> #include <coreplugin/minisplitter.h>

2
src/plugins/perfprofiler/perfprofilerstatisticsview.h
View File

@@ -3,8 +3,6 @@
#pragma once #pragma once
#include "perftimelinemodel.h"
#include <QWidget> #include <QWidget>
namespace PerfProfiler { namespace PerfProfiler {

6
src/plugins/perfprofiler/perfprofilertool.cpp
View File

@@ -100,7 +100,7 @@ PerfProfilerTool::PerfProfilerTool()
command = Core::ActionManager::registerAction(m_showFullRange, command = Core::ActionManager::registerAction(m_showFullRange,
Constants::PerfProfilerTaskFullRange, Constants::PerfProfilerTaskFullRange,
globalContext); globalContext);
connect(m_showFullRange, &QAction::triggered, this, [this]() { connect(m_showFullRange, &QAction::triggered, this, [] {
traceManager().restrictByFilter(traceManager().rangeAndThreadFilter(-1, -1)); traceManager().restrictByFilter(traceManager().rangeAndThreadFilter(-1, -1));
}); });
options->addAction(command); options->addAction(command);
@@ -179,7 +179,7 @@ void PerfProfilerTool::createViews()
m_statisticsView = new PerfProfilerStatisticsView; m_statisticsView = new PerfProfilerStatisticsView;
m_statisticsView->setWindowTitle(Tr::tr("Statistics")); m_statisticsView->setWindowTitle(Tr::tr("Statistics"));
m_flameGraphView = new PerfProfilerFlameGraphView(nullptr, this); m_flameGraphView = new PerfProfilerFlameGraphView(nullptr);
m_flameGraphView->setWindowTitle(Tr::tr("Flame Graph")); m_flameGraphView->setWindowTitle(Tr::tr("Flame Graph"));
connect(m_statisticsView, &PerfProfilerStatisticsView::gotoSourceLocation, connect(m_statisticsView, &PerfProfilerStatisticsView::gotoSourceLocation,
@@ -500,7 +500,7 @@ void PerfProfilerTool::updateFilterMenu()
if (thread.tid == 0) { if (thread.tid == 0) {
action->setEnabled(false); action->setEnabled(false);
} else { } else {
connect(action, &QAction::toggled, this, [this, action](bool checked) { connect(action, &QAction::toggled, this, [action](bool checked) {
traceManager().setThreadEnabled(action->data().toUInt(), checked); traceManager().setThreadEnabled(action->data().toUInt(), checked);
}); });
connect(enableAll, &QAction::triggered, connect(enableAll, &QAction::triggered,