diff --git a/src/plugins/cpptools/cppmodelmanager.cpp b/src/plugins/cpptools/cppmodelmanager.cpp index 13b582cfed0..2ffd37c14e5 100644 --- a/src/plugins/cpptools/cppmodelmanager.cpp +++ b/src/plugins/cpptools/cppmodelmanager.cpp @@ -56,6 +56,7 @@ #include #include #include +#include #include #include #include @@ -131,6 +132,7 @@ public: // Project integration mutable QMutex m_projectMutex; QMap m_projectToProjectsInfo; + QHash m_projectToIndexerCanceled; QMap > m_fileToProjectParts; QMap m_projectPartIdToProjectProjectPart; // The members below are cached/(re)calculated from the projects and/or their project parts @@ -759,6 +761,25 @@ void CppModelManager::recalculateProjectPartMappings() d->m_symbolFinder.clearCache(); } +void CppModelManager::watchForCanceledProjectIndexer(QFuture future, + ProjectExplorer::Project *project) +{ + d->m_projectToIndexerCanceled.insert(project, false); + + if (future.isCanceled() || future.isFinished()) + return; + + QFutureWatcher *watcher = new QFutureWatcher(); + connect(watcher, &QFutureWatcher::canceled, this, [this, project]() { + if (d->m_projectToIndexerCanceled.contains(project)) // Project not yet removed + d->m_projectToIndexerCanceled.insert(project, true); + }); + connect(watcher, &QFutureWatcher::finished, this, [watcher]() { + watcher->deleteLater(); + }); + watcher->setFuture(future); +} + void CppModelManager::updateCppEditorDocuments() const { // Refresh visible documents @@ -792,16 +813,17 @@ QFuture CppModelManager::updateProjectInfo(const ProjectInfo &newProjectIn QSet filesToReindex; QStringList removedProjectParts; bool filesRemoved = false; + ProjectExplorer::Project *project = newProjectInfo.project().data(); { // Only hold the mutex for a limited scope, so the dumping afterwards does not deadlock. QMutexLocker projectLocker(&d->m_projectMutex); - ProjectExplorer::Project *project = newProjectInfo.project().data(); const QSet newSourceFiles = newProjectInfo.sourceFiles(); // Check if we can avoid a full reindexing ProjectInfo oldProjectInfo = d->m_projectToProjectsInfo.value(project); - if (oldProjectInfo.isValid()) { + const bool previousIndexerCanceled = d->m_projectToIndexerCanceled.value(project, false); + if (!previousIndexerCanceled && oldProjectInfo.isValid()) { ProjectInfoComparer comparer(oldProjectInfo, newProjectInfo); if (comparer.configurationOrFilesChanged()) { @@ -872,7 +894,10 @@ QFuture CppModelManager::updateProjectInfo(const ProjectInfo &newProjectIn updateCppEditorDocuments(); // Trigger reindexing - return updateSourceFiles(filesToReindex, ForcedProgressNotification); + QFuture indexerFuture = updateSourceFiles(filesToReindex, ForcedProgressNotification); + watchForCanceledProjectIndexer(indexerFuture, project); + + return indexerFuture; } ProjectPart::Ptr CppModelManager::projectPartForId(const QString &projectPartId) const @@ -970,6 +995,8 @@ void CppModelManager::onAboutToRemoveProject(ProjectExplorer::Project *project) { QStringList projectPartIds; + d->m_projectToIndexerCanceled.remove(project); + { QMutexLocker locker(&d->m_projectMutex); d->m_dirty = true; diff --git a/src/plugins/cpptools/cppmodelmanager.h b/src/plugins/cpptools/cppmodelmanager.h index 41ec74ee670..3a42c650344 100644 --- a/src/plugins/cpptools/cppmodelmanager.h +++ b/src/plugins/cpptools/cppmodelmanager.h @@ -206,6 +206,7 @@ private: void initializeBuiltinModelManagerSupport(); void delayedGC(); void recalculateProjectPartMappings(); + void watchForCanceledProjectIndexer(QFuture future, ProjectExplorer::Project *project); void replaceSnapshot(const CPlusPlus::Snapshot &newSnapshot); void removeFilesFromSnapshot(const QSet &removedFiles);