From 53bae17b96f7c718069d719801a73a927049239a Mon Sep 17 00:00:00 2001 From: David Schulz Date: Mon, 22 Nov 2021 10:29:16 +0100 Subject: [PATCH] CDB: always set stop reason when handling exceptions Otherwise we get an unknown stop reason which might get handled differently in the cdbengine. Fixes: QTCREATORBUG-26506 Change-Id: Ia1622977631190d43a6b599b58410953cd2add6e Reviewed-by: Christian Stenger --- src/libs/qtcreatorcdbext/eventcallback.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libs/qtcreatorcdbext/eventcallback.cpp b/src/libs/qtcreatorcdbext/eventcallback.cpp index caafd9c3e2f..2e887f5de92 100644 --- a/src/libs/qtcreatorcdbext/eventcallback.cpp +++ b/src/libs/qtcreatorcdbext/eventcallback.cpp @@ -173,14 +173,14 @@ STDMETHODIMP EventCallback::Exception( __in ULONG FirstChance ) { + const ExtensionContext::StopReasonMap parameters = exceptionParameters(*Ex, FirstChance); + ExtensionContext::instance().setStopReason(parameters, "exception"); if ((FirstChance && ExtensionContext::instance().parameters().firstChanceException != 0) || (!FirstChance && ExtensionContext::instance().parameters().secondChanceException != 0)) { // Report the exception as GBMI and set potential stop reason - const ExtensionContext::StopReasonMap parameters = exceptionParameters(*Ex, FirstChance); std::ostringstream str; formatGdbmiHash(str, parameters); - ExtensionContext::instance().setStopReason(parameters, "exception"); ExtensionContext::instance().report('E', 0, 0, "exception", "%s", str.str().c_str()); } return m_wrapped ? m_wrapped->Exception(Ex, FirstChance) : S_OK;