From 53d3ae80c8efc47f95e28cf604e0388781ae93df Mon Sep 17 00:00:00 2001 From: hjk Date: Mon, 16 Jun 2025 16:52:50 +0200 Subject: [PATCH] ProjectExplorer: Simplify some TaskHandler::canHandle() implementations Change-Id: I957b40b8e920818a7dadf1d3edc01dc5ab8d2077 Reviewed-by: Christian Kandeler --- src/plugins/projectexplorer/taskhandlers.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/plugins/projectexplorer/taskhandlers.cpp b/src/plugins/projectexplorer/taskhandlers.cpp index 52b19336a72..4479d59e6bc 100644 --- a/src/plugins/projectexplorer/taskhandlers.cpp +++ b/src/plugins/projectexplorer/taskhandlers.cpp @@ -196,10 +196,7 @@ private: bool canHandle(const Task &task) const override { - if (task.file.isEmpty()) - return false; - QFileInfo fi(task.file.toFileInfo()); - return fi.exists() && fi.isFile() && fi.isReadable(); + return task.file.isReadableFile(); } void handle(const Task &task) override @@ -227,8 +224,7 @@ public: private: bool canHandle(const Task &task) const override { - QFileInfo fi(task.file.toFileInfo()); - if (!fi.exists() || !fi.isFile() || !fi.isReadable()) + if (!task.file.isReadableFile()) return false; IVersionControl *vc = VcsManager::findVersionControlForDirectory(task.file.absolutePath()); if (!vc)