From 54205c1b6272cc2317dbea05a768854bc303ac1e Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Mon, 11 Mar 2024 15:05:38 +0100 Subject: [PATCH] Axivion: Replace local lambda with static method No need to create lambda on every call to credentialKey(). This should remove the warning about the Performance inefficiencies (AUTO_CAUSES_COPY). Change-Id: I9a7dc9cabcc6f80e58e39ef8be6a5445a11e0433 Reviewed-by: Christian Stenger --- src/plugins/axivion/axivionplugin.cpp | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/plugins/axivion/axivionplugin.cpp b/src/plugins/axivion/axivionplugin.cpp index 7ce0c4ffe18..a5431b6069d 100644 --- a/src/plugins/axivion/axivionplugin.cpp +++ b/src/plugins/axivion/axivionplugin.cpp @@ -119,13 +119,15 @@ static QString apiTokenDescription() return "Automatically created by " + ua + " on " + user + "@" + QSysInfo::machineHostName(); } +static QString escapeKey(const QString &string) +{ + QString escaped = string; + return escaped.replace('\\', "\\\\").replace('@', "\\@"); +} + static QString credentialKey() { - const auto escape = [](const QString &string) { - QString escaped = string; - return escaped.replace('\\', "\\\\").replace('@', "\\@"); - }; - return escape(settings().server.username) + '@' + escape(settings().server.dashboard); + return escapeKey(settings().server.username) + '@' + escapeKey(settings().server.dashboard); } template