From 5434ea417f245829f95fe05f885dcfcfcf942c4c Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Wed, 20 Jul 2022 16:31:55 +0200 Subject: [PATCH] ProjectConfigurationModel: Avoid using sender() Change-Id: I65a2da1f2e8a5d3bb98bda752942d83e4074df9d Reviewed-by: Christian Kandeler --- src/plugins/projectexplorer/projectconfigurationmodel.cpp | 8 ++------ src/plugins/projectexplorer/projectconfigurationmodel.h | 2 +- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/src/plugins/projectexplorer/projectconfigurationmodel.cpp b/src/plugins/projectexplorer/projectconfigurationmodel.cpp index 9889b917da7..bdde8241572 100644 --- a/src/plugins/projectexplorer/projectconfigurationmodel.cpp +++ b/src/plugins/projectexplorer/projectconfigurationmodel.cpp @@ -64,12 +64,8 @@ int ProjectConfigurationModel::columnCount(const QModelIndex &parent) const return parent.isValid() ? 0 : 1; } -void ProjectConfigurationModel::displayNameChanged() +void ProjectConfigurationModel::displayNameChanged(ProjectConfiguration *pc) { - auto pc = qobject_cast(sender()); - if (!pc) - return; - // Find the old position int oldPos = m_projectConfigurations.indexOf(pc); if (oldPos < 0) @@ -148,7 +144,7 @@ void ProjectConfigurationModel::addProjectConfiguration(ProjectConfiguration *pc endInsertRows(); connect(pc, &ProjectConfiguration::displayNameChanged, - this, &ProjectConfigurationModel::displayNameChanged); + this, [this, pc] { displayNameChanged(pc); }); } void ProjectConfigurationModel::removeProjectConfiguration(ProjectConfiguration *pc) diff --git a/src/plugins/projectexplorer/projectconfigurationmodel.h b/src/plugins/projectexplorer/projectconfigurationmodel.h index d3d68b3bfba..ecb21f6767f 100644 --- a/src/plugins/projectexplorer/projectconfigurationmodel.h +++ b/src/plugins/projectexplorer/projectconfigurationmodel.h @@ -52,7 +52,7 @@ public: void removeProjectConfiguration(ProjectConfiguration *pc); private: - void displayNameChanged(); + void displayNameChanged(ProjectConfiguration *pc); Target *m_target; QList m_projectConfigurations;