feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Code cosmetics

Browse Source 
Change-Id: I52a0f5d842917459ba05a0423402ffebd640db61
Reviewed-by: hjk <hjk121@nokiamail.com>
This commit is contained in:
hjk
2014-06-05 14:55:50 +02:00
parent 946ab99b9f
commit 544e07d114
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/debugger/debuggerconstants.h
View File

@@ -64,9 +64,6 @@ const char QML_UPDATE_ON_SAVE[] = "Debugger.QmlUpdateOnSave";
const char QML_SELECTTOOL[] = "Debugger.QmlSelectTool"; const char QML_SELECTTOOL[] = "Debugger.QmlSelectTool";
const char QML_ZOOMTOOL[] = "Debugger.QmlZoomTool"; const char QML_ZOOMTOOL[] = "Debugger.QmlZoomTool";
// VariableManager Prefix
const char PrefixDebugExecutable[] = "DebuggedExecutable";
const char TASK_CATEGORY_DEBUGGER_DEBUGINFO[] = "Debuginfo"; const char TASK_CATEGORY_DEBUGGER_DEBUGINFO[] = "Debuginfo";
const char TASK_CATEGORY_DEBUGGER_RUNTIME[] = "DebugRuntime"; const char TASK_CATEGORY_DEBUGGER_RUNTIME[] = "DebugRuntime";

13
src/plugins/debugger/debuggerengine.cpp
View File

@@ -92,6 +92,9 @@ enum { debug = 0 };
// //
/////////////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////////////
// VariableManager Prefix
const char PrefixDebugExecutable[] = "DebuggedExecutable";
namespace Debugger { namespace Debugger {
Internal::Location::Location(const StackFrame &frame, bool marker) Internal::Location::Location(const StackFrame &frame, bool marker)
@@ -172,7 +175,7 @@ public:
connect(&m_locationTimer, SIGNAL(timeout()), SLOT(resetLocation())); connect(&m_locationTimer, SIGNAL(timeout()), SLOT(resetLocation()));
connect(debuggerCore()->action(IntelFlavor), SIGNAL(valueChanged(QVariant)), connect(debuggerCore()->action(IntelFlavor), SIGNAL(valueChanged(QVariant)),
SLOT(reloadDisassembly())); SLOT(reloadDisassembly()));
VariableManager::registerFileVariables(Constants::PrefixDebugExecutable, VariableManager::registerFileVariables(PrefixDebugExecutable,
tr("Debugged executable")); tr("Debugged executable"));
connect(VariableManager::instance(), SIGNAL(variableUpdateRequested(QByteArray)), connect(VariableManager::instance(), SIGNAL(variableUpdateRequested(QByteArray)),
SLOT(updateVariable(QByteArray))); SLOT(updateVariable(QByteArray)));
@@ -187,11 +190,11 @@ public slots:
void doInterruptInferior(); void doInterruptInferior();
void doFinishDebugger(); void doFinishDebugger();
void updateVariable(QByteArray variable) void updateVariable(const QByteArray &variable)
{ {
if (VariableManager::isFileVariable(variable, Constants::PrefixDebugExecutable)) if (VariableManager::isFileVariable(variable, PrefixDebugExecutable))
VariableManager::insert(variable, VariableManager::fileVariableValue(variable, VariableManager::insert(variable,
Constants::PrefixDebugExecutable, QFileInfo(m_startParameters.executable))); VariableManager::fileVariableValue(variable, PrefixDebugExecutable, m_startParameters.executable));
} }
void reloadDisassembly() void reloadDisassembly()