feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

VcsBase: Use override consistently

Browse Source 
clang-tidy fixes from modernize-use-override check.

Change-Id: I4775c493dbeefaf832b862f8740f216a3aacbfc6
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Tobias Hunger
2018-05-07 15:02:04 +02:00
parent e7d13245a4
commit 5451413c2d
4 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/vcsbase/baseannotationhighlighter.h
View File

@@ -45,9 +45,9 @@ public:
void setChangeNumbers(const ChangeNumbers &changeNumbers); void setChangeNumbers(const ChangeNumbers &changeNumbers);
virtual void highlightBlock(const QString &text) override; void highlightBlock(const QString &text) override;
virtual void setFontSettings(const TextEditor::FontSettings &fontSettings) override; void setFontSettings(const TextEditor::FontSettings &fontSettings) override;
private: private:
// Implement this to return the change number of a line // Implement this to return the change number of a line

2
src/plugins/vcsbase/diffandloghighlighter.h
View File

@@ -51,7 +51,7 @@ public:
void highlightBlock(const QString &text) override; void highlightBlock(const QString &text) override;
virtual void setFontSettings(const TextEditor::FontSettings &fontSettings) override; void setFontSettings(const TextEditor::FontSettings &fontSettings) override;
private: private:
friend class DiffAndLogHighlighterPrivate; friend class DiffAndLogHighlighterPrivate;

2
src/plugins/vcsbase/vcsbasediffeditorcontroller.h
View File

@@ -43,7 +43,7 @@ public:
VcsBaseDiffEditorController(Core::IDocument *document, VcsBaseDiffEditorController(Core::IDocument *document,
VcsBaseClientImpl *client, VcsBaseClientImpl *client,
const QString &workingDirectory); const QString &workingDirectory);
~VcsBaseDiffEditorController(); ~VcsBaseDiffEditorController() override;
protected: protected:
void runCommand(const QList<QStringList> &args, unsigned flags, QTextCodec *codec = nullptr); void runCommand(const QList<QStringList> &args, unsigned flags, QTextCodec *codec = nullptr);

4
src/plugins/vcsbase/vcsbaseoptionspage.h
View File

@@ -69,8 +69,8 @@ public:
explicit VcsClientOptionsPage(Core::IVersionControl *control, VcsBaseClientImpl *client, QObject *parent = 0); explicit VcsClientOptionsPage(Core::IVersionControl *control, VcsBaseClientImpl *client, QObject *parent = 0);
VcsClientOptionsPageWidget *widget() override; VcsClientOptionsPageWidget *widget() override;
virtual void apply() override; void apply() override;
virtual void finish() override; void finish() override;
signals: signals:
void settingsChanged(); void settingsChanged();