feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CorePlugin: Remove foreach / Q_FOREACH usage

Browse Source 
Task-number: QTCREATORBUG-27464
Change-Id: I0d0257bbd46f3eec9b11b386d1987156e83a9dac
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Artem Sokolovskii
2022-05-02 11:22:55 +02:00
parent 71b84417b3
commit 54628488a4
14 changed files with 38 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/coreplugin/navigationwidget.cpp
View File

@@ -244,7 +244,7 @@ QWidget *NavigationWidget::activateSubWidget(Id factoryId, Side fallbackSide)
void NavigationWidget::setFactories(const QList<INavigationWidgetFactory *> &factories)
{
Context navicontext(Constants::C_NAVIGATION_PANE);
foreach (INavigationWidgetFactory *factory, factories) {
for (INavigationWidgetFactory *factory : qAsConst(factories)) {
const Id id = factory->id();
const Id actionId = id.withPrefix("QtCreator.Sidebar.");
@@ -349,7 +349,7 @@ Internal::NavigationSubWidget *NavigationWidget::insertSubItem(int position, int
QWidget *NavigationWidget::activateSubWidget(Id factoryId, int preferredPosition)
{
setShown(true);
foreach (Internal::NavigationSubWidget *subWidget, d->m_subWidgets) {
for (Internal::NavigationSubWidget *subWidget : qAsConst(d->m_subWidgets)) {
if (subWidget->factory()->id() == factoryId) {
subWidget->setFocusWidget();
ICore::raiseWindow(this);
@@ -457,7 +457,7 @@ void NavigationWidget::restoreSettings(QSettings *settings)
}
int position = 0;
foreach (const QString &id, viewIds) {
for (const QString &id : qAsConst(viewIds)) {
int index = factoryIndex(Id::fromString(id));
if (index >= 0) {
// Only add if the id was actually found!
@@ -509,7 +509,7 @@ void NavigationWidget::restoreSettings(QSettings *settings)
void NavigationWidget::closeSubWidgets()
{
foreach (Internal::NavigationSubWidget *subWidget, d->m_subWidgets) {
for (Internal::NavigationSubWidget *subWidget : qAsConst(d->m_subWidgets)) {
subWidget->saveSettings();
delete subWidget;
}