From 546d4a3b1a7c0996fa9d730c9b0ccf59bea9d1cb Mon Sep 17 00:00:00 2001 From: David Schulz Date: Wed, 18 Dec 2019 07:40:05 +0100 Subject: [PATCH] WinRT: Move some device detection output into a logging category This hides the detection failing in the case when no winrtrunner.exe can be found, which is given as soon as you do not have a UWP Qt installed. So moving this output to logging category makes it still accessible, but it doesn't confuse non UWP developer. Change-Id: Ie1434f75086d435f8f033b58c010e35fe64658b0 Reviewed-by: Christian Stenger --- src/plugins/winrt/winrtdevice.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/plugins/winrt/winrtdevice.cpp b/src/plugins/winrt/winrtdevice.cpp index cf99e212b03..a8458ace905 100644 --- a/src/plugins/winrt/winrtdevice.cpp +++ b/src/plugins/winrt/winrtdevice.cpp @@ -137,10 +137,9 @@ WinRtDeviceFactory::WinRtDeviceFactory(Core::Id deviceType) void WinRtDeviceFactory::autoDetect() { qCDebug(winrtDeviceLog) << __FUNCTION__; - MessageManager::write(tr("Running Windows Runtime device detection.")); const QString runnerFilePath = findRunnerFilePath(); if (runnerFilePath.isEmpty()) { - MessageManager::write(tr("No winrtrunner.exe found.")); + qCDebug(winrtDeviceLog) << "No winrtrunner.exe found."; return; } @@ -155,7 +154,6 @@ void WinRtDeviceFactory::autoDetect() const CommandLine cmd{runnerFilePath, {"--list-devices"}}; m_process->setCommand(cmd); qCDebug(winrtDeviceLog) << __FUNCTION__ << "Starting process" << cmd.toUserOutput(); - MessageManager::write(cmd.toUserOutput()); m_process->start(); qCDebug(winrtDeviceLog) << __FUNCTION__ << "Process started"; } @@ -361,7 +359,7 @@ void WinRtDeviceFactory::parseRunnerOutput(const QByteArray &output) const message += QLatin1Char(' '); message += tr("%n of them are new.", nullptr, numNew); } - MessageManager::write(message); + qCDebug(winrtDeviceLog) << message; } } // Internal