feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Android: warn about wrong ABI in issues pane instead of general messages

Browse Source 
Change-Id: I7b11b0b91f2843ee3d95d86b9afc772295dd6e94
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Assam Boudjelthia
2020-08-11 17:53:44 +03:00
parent 56e4595fd8
commit 54b1aaed03
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/android/androiddeployqtstep.cpp
View File

@@ -45,6 +45,7 @@
#include <projectexplorer/projectnodes.h> #include <projectexplorer/projectnodes.h>
#include <projectexplorer/runconfiguration.h> #include <projectexplorer/runconfiguration.h>
#include <projectexplorer/target.h> #include <projectexplorer/target.h>
#include <projectexplorer/taskhub.h>
#include <projectexplorer/toolchain.h> #include <projectexplorer/toolchain.h>
#include <qtsupport/qtkitinformation.h> #include <qtsupport/qtkitinformation.h>
@@ -212,12 +213,12 @@ bool AndroidDeployQtStep::init()
auto selectedAbis = buildSystem()->extraData(buildKey, Constants::ANDROID_ABIS).toStringList(); auto selectedAbis = buildSystem()->extraData(buildKey, Constants::ANDROID_ABIS).toStringList();
if (!selectedAbis.contains(info.cpuAbi.first())) { if (!selectedAbis.contains(info.cpuAbi.first())) {
Core::MessageManager::write( TaskHub::addTask(DeploymentTask(
Task::Warning,
tr("Android: The main ABI of the deployment device (%1) is not selected! The app " tr("Android: The main ABI of the deployment device (%1) is not selected! The app "
"execution or debugging might not work properly. Add it from Projects > Build > " "execution or debugging might not work properly. Add it from Projects > Build > "
"Build Steps > qmake > ABIs.") "Build Steps > qmake > ABIs.")
.arg(info.cpuAbi.first()), .arg(info.cpuAbi.first())));
Core::MessageManager::WithFocus);
} }
m_avdName = info.avdname; m_avdName = info.avdname;