diff --git a/plugins/autotest/autotestconstants.h b/plugins/autotest/autotestconstants.h index ed9c4951493..04b4ac04247 100644 --- a/plugins/autotest/autotestconstants.h +++ b/plugins/autotest/autotestconstants.h @@ -36,8 +36,18 @@ const char TASK_PARSE[] = "AutoTest.Task.Parse"; const char UNNAMED_QUICKTESTS[] = QT_TR_NOOP(""); const char AUTOTEST_SETTINGS_CATEGORY[] = "ZY.Tests"; -} // namespace Autotest } // namespace Constants +namespace Internal { + +enum TestType +{ + TestTypeQt, + TestTypeGTest +}; + +} // namespace Internal +} // namespace Autotest + #endif // AUTOTESTCONSTANTS_H diff --git a/plugins/autotest/testconfiguration.cpp b/plugins/autotest/testconfiguration.cpp index 3cf60556586..96ceaf2a98f 100644 --- a/plugins/autotest/testconfiguration.cpp +++ b/plugins/autotest/testconfiguration.cpp @@ -43,7 +43,7 @@ TestConfiguration::TestConfiguration(const QString &testClass, const QStringList m_unnamedOnly(false), m_project(0), m_guessedConfiguration(false), - m_type(Qt) + m_type(TestTypeQt) { if (testCases.size() != 0) m_testCaseCount = testCases.size(); diff --git a/plugins/autotest/testconfiguration.h b/plugins/autotest/testconfiguration.h index 1b2d34e0873..7b39ae879cb 100644 --- a/plugins/autotest/testconfiguration.h +++ b/plugins/autotest/testconfiguration.h @@ -20,6 +20,8 @@ #ifndef TESTCONFIGURATION_H #define TESTCONFIGURATION_H +#include "autotestconstants.h" + #include #include @@ -37,11 +39,6 @@ class TestConfiguration : public QObject { Q_OBJECT public: - enum TestType { - Qt, - GTest - }; - explicit TestConfiguration(const QString &testClass, const QStringList &testCases, int testCaseCount = 0, QObject *parent = 0); ~TestConfiguration(); diff --git a/plugins/autotest/testresult.cpp b/plugins/autotest/testresult.cpp index 5885c1c400a..ba75fb5246e 100644 --- a/plugins/autotest/testresult.cpp +++ b/plugins/autotest/testresult.cpp @@ -37,7 +37,7 @@ TestResult::TestResult(const QString &className) : m_class(className) , m_result(Result::Invalid) , m_line(0) - , m_type(Qt) + , m_type(TestTypeQt) { } @@ -155,7 +155,7 @@ QTestResult::QTestResult(const QString &className) GTestResult::GTestResult(const QString &className) : TestResult(className) { - setTestType(GTest); + setTestType(TestTypeGTest); } } // namespace Internal diff --git a/plugins/autotest/testresult.h b/plugins/autotest/testresult.h index a6c4f3e32a1..b4226da5728 100644 --- a/plugins/autotest/testresult.h +++ b/plugins/autotest/testresult.h @@ -20,6 +20,8 @@ #ifndef TESTRESULT_H #define TESTRESULT_H +#include "autotestconstants.h" + #include #include #include @@ -58,12 +60,6 @@ enum Type { class TestResult { public: - enum TestType - { - Qt, - GTest - }; - TestResult(); TestResult(const QString &className); diff --git a/plugins/autotest/testresultdelegate.cpp b/plugins/autotest/testresultdelegate.cpp index a1ca6f9fe43..a9a59b7f34e 100644 --- a/plugins/autotest/testresultdelegate.cpp +++ b/plugins/autotest/testresultdelegate.cpp @@ -48,9 +48,9 @@ QString TestResultDelegate::outputString(const TestResult &testResult, bool sele case Result::UnexpectedPass: case Result::BlacklistedFail: case Result::BlacklistedPass: - if (testResult.type() == TestResult::Qt) + if (testResult.type() == TestTypeQt) output = testResult.className() + QLatin1String("::") + testResult.testCase(); - else // TestResult::GTest + else // TestTypeGTest output = testResult.testCase(); if (!testResult.dataTag().isEmpty()) output.append(QString::fromLatin1(" (%1)").arg(testResult.dataTag())); diff --git a/plugins/autotest/testrunner.cpp b/plugins/autotest/testrunner.cpp index eae29bec951..84d500ccdcf 100644 --- a/plugins/autotest/testrunner.cpp +++ b/plugins/autotest/testrunner.cpp @@ -142,8 +142,8 @@ void performTestRun(QFutureInterface &futureInterface, if (connection) QObject::disconnect(connection); - TestConfiguration::TestType testType = testConfiguration->testType(); - if (testType == TestConfiguration::Qt) { + TestType testType = testConfiguration->testType(); + if (testType == TestTypeQt) { connection = QObject::connect(&testProcess, &QProcess::readyRead, &outputReader, &TestOutputReader::processOutput); } else { @@ -166,14 +166,14 @@ void performTestRun(QFutureInterface &futureInterface, continue; } - if (testType == TestConfiguration::Qt) { + if (testType == TestTypeQt) { QStringList argumentList(QLatin1String("-xml")); if (!metricsOption.isEmpty()) argumentList << metricsOption; if (testConfiguration->testCases().count()) argumentList << testConfiguration->testCases(); testProcess.setArguments(argumentList); - } else { // TestConfiguration::GTest + } else { // TestTypeGTest const QStringList &testSets = testConfiguration->testCases(); if (testSets.size()) { QStringList argumentList; diff --git a/plugins/autotest/testtreemodel.cpp b/plugins/autotest/testtreemodel.cpp index 507e18da20c..49e2070839d 100644 --- a/plugins/autotest/testtreemodel.cpp +++ b/plugins/autotest/testtreemodel.cpp @@ -256,7 +256,7 @@ QList TestTreeModel::getAllTestCases() const foundMains.value(proFile)); tc->setProFile(proFile); tc->setProject(project); - tc->setTestType(TestConfiguration::GTest); + tc->setTestType(TestTypeGTest); result << tc; } @@ -398,7 +398,7 @@ QList TestTreeModel::getSelectedTests() const foreach (const QString &proFile, proFilesWithEnabledTestSets.keys()) { TestConfiguration *tc = new TestConfiguration(QString(), proFilesWithEnabledTestSets.value(proFile)); - tc->setTestType(TestConfiguration::GTest); + tc->setTestType(TestTypeGTest); tc->setProFile(proFile); tc->setProject(project); result << tc; @@ -468,7 +468,7 @@ TestConfiguration *TestTreeModel::getTestConfiguration(const TestTreeItem *item) config->setTestCaseCount(childCount); config->setProFile(item->childItem(0)->mainFile()); config->setProject(project); - config->setTestType(TestConfiguration::GTest); + config->setTestType(TestTypeGTest); } break; } @@ -478,7 +478,7 @@ TestConfiguration *TestTreeModel::getTestConfiguration(const TestTreeItem *item) QStringList(parent->name() + QLatin1Char('.') + item->name())); config->setProFile(item->mainFile()); config->setProject(project); - config->setTestType(TestConfiguration::GTest); + config->setTestType(TestTypeGTest); break; } // not supported items