From 553f4bec7e290cb3a4a34e4a3fd279bec79bf066 Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Fri, 24 Sep 2021 13:11:31 +0200 Subject: [PATCH] ClangCodeModel: Remove inapplicable TODO item It's not worth the extra effort to restrict the identifier <-> file name check to data types: There is hardly any possibility for a completely false positive, as local variables do not pass through this code path. Change-Id: Ia92549c8c6723e520789a2ad820a2606620d4efe Reviewed-by: David Schulz --- src/plugins/clangcodemodel/clangdclient.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/clangcodemodel/clangdclient.cpp b/src/plugins/clangcodemodel/clangdclient.cpp index 23b6f5c0a8f..f8145206ff7 100644 --- a/src/plugins/clangcodemodel/clangdclient.cpp +++ b/src/plugins/clangcodemodel/clangdclient.cpp @@ -1230,7 +1230,7 @@ void ClangdClient::Private::addSearchResultsForFile(ReferencesData &refData, if (fileInSession && file.baseName().compare( refData.replacementData->oldSymbolName, Qt::CaseInsensitive) == 0) { - refData.replacementData->fileRenameCandidates << file; // TODO: We want to do this only for types. Use SymbolInformation once we have it. + refData.replacementData->fileRenameCandidates << file; } } items << item;