From 55cccfa59eb68dd59de90939063acda56241c082 Mon Sep 17 00:00:00 2001
From: Cristian Adam <cristian.adam@qt.io>
Date: Fri, 20 Oct 2023 15:00:44 +0200
Subject: [PATCH] CMakePM: clang-tidy fix for 'no-automatic-move'

See https://releases.llvm.org/17.0.1/tools/clang/tools/extra/docs/clang-
tidy/checks/performance/no-automatic-move.html

Change-Id: If265c9b0e2aea49e5923f079cd621e10bb958286
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
---
 src/plugins/cmakeprojectmanager/cmakebuildstep.cpp   | 2 +-
 src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp | 2 +-
 src/plugins/cmakeprojectmanager/cmaketool.cpp        | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/plugins/cmakeprojectmanager/cmakebuildstep.cpp b/src/plugins/cmakeprojectmanager/cmakebuildstep.cpp
index 8187311a887..31a6ae23c02 100644
--- a/src/plugins/cmakeprojectmanager/cmakebuildstep.cpp
+++ b/src/plugins/cmakeprojectmanager/cmakebuildstep.cpp
@@ -372,7 +372,7 @@ GroupItem CMakeBuildStep::runRecipe()
     const auto onEnd = [this] {
         updateDeploymentData();
     };
-    const Group root {
+    Group root {
         ignoreReturnValue() ? finishAllAndDone : stopOnError,
         ProjectParserTask(onParserSetup, {}, onParserError),
         defaultProcessTask(),
diff --git a/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp b/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp
index 7f7ebccdd0a..7c0001c6a86 100644
--- a/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp
+++ b/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp
@@ -1532,7 +1532,7 @@ void CMakeBuildSystem::runCTest()
                     if (bt != -1) {
                         QSet<int> seen;
                         std::function<QJsonObject(int)> findAncestor = [&](int index){
-                            const QJsonObject node = nodes.at(index).toObject();
+                            QJsonObject node = nodes.at(index).toObject();
                             const int parent = node.value("parent").toInt(-1);
                             if (parent < 0 || !Utils::insert(seen, parent))
                                 return node;
diff --git a/src/plugins/cmakeprojectmanager/cmaketool.cpp b/src/plugins/cmakeprojectmanager/cmaketool.cpp
index f9d7149a344..fdaf5e6bfc6 100644
--- a/src/plugins/cmakeprojectmanager/cmaketool.cpp
+++ b/src/plugins/cmakeprojectmanager/cmaketool.cpp
@@ -228,7 +228,7 @@ FilePath CMakeTool::cmakeExecutable(const FilePath &path)
         }
     }
 
-    const FilePath resolvedPath = path.canonicalPath();
+    FilePath resolvedPath = path.canonicalPath();
     // Evil hack to make snap-packages of CMake work. See QTCREATORBUG-23376
     if (path.osType() == OsTypeLinux && resolvedPath.fileName() == "snap")
         return path;