From 55ed34ced83f6f9f8cbabaf5532c7b46da8ddf65 Mon Sep 17 00:00:00 2001
From: hjk <hjk@qt.io>
Date: Thu, 29 Sep 2022 12:37:37 +0200
Subject: [PATCH] CMakeProjectManager: Use QList in PresetsData
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Less impedance when interfacing the rest of the code.

Fixes

     warning: comparison of integer expressions of different signedness:
     ‘std::vector<....>::size_type’ {aka ‘long unsigned int’} and
     ‘qsizetype’ {aka ‘long long int’} [-Wsign-compare]

Change-Id: If5e1e770e2ed170aa4259963fa7ca0d6642190d9
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
---
 src/plugins/cmakeprojectmanager/presetsparser.cpp | 4 ++--
 src/plugins/cmakeprojectmanager/presetsparser.h   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/plugins/cmakeprojectmanager/presetsparser.cpp b/src/plugins/cmakeprojectmanager/presetsparser.cpp
index 47e46cb0137..98c335975a6 100644
--- a/src/plugins/cmakeprojectmanager/presetsparser.cpp
+++ b/src/plugins/cmakeprojectmanager/presetsparser.cpp
@@ -35,7 +35,7 @@ bool parseCMakeMinimumRequired(const QJsonValue &jsonValue, QVersionNumber &vers
 }
 
 bool parseConfigurePresets(const QJsonValue &jsonValue,
-                           std::vector<PresetsDetails::ConfigurePreset> &configurePresets)
+                           QList<PresetsDetails::ConfigurePreset> &configurePresets)
 {
     // The whole section is optional
     if (jsonValue.isUndefined())
@@ -185,7 +185,7 @@ bool parseConfigurePresets(const QJsonValue &jsonValue,
 }
 
 bool parseBuildPresets(const QJsonValue &jsonValue,
-                       std::vector<PresetsDetails::BuildPreset> &buildPresets)
+                       QList<PresetsDetails::BuildPreset> &buildPresets)
 {
     // The whole section is optional
     if (jsonValue.isUndefined())
diff --git a/src/plugins/cmakeprojectmanager/presetsparser.h b/src/plugins/cmakeprojectmanager/presetsparser.h
index c067507a2a2..17076dfa770 100644
--- a/src/plugins/cmakeprojectmanager/presetsparser.h
+++ b/src/plugins/cmakeprojectmanager/presetsparser.h
@@ -96,8 +96,8 @@ public:
     int version = 0;
     QVersionNumber cmakeMinimimRequired;
     QHash<QString, QString> vendor;
-    std::vector<PresetsDetails::ConfigurePreset> configurePresets;
-    std::vector<PresetsDetails::BuildPreset> buildPresets;
+    QList<PresetsDetails::ConfigurePreset> configurePresets;
+    QList<PresetsDetails::BuildPreset> buildPresets;
 };
 
 class PresetsParser