feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ClassView: Avoid mixing const and non-const iterators

Browse Source 
Change-Id: I27e35b0225345de7b335dd8ac3a1af5fd5cf164e
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
This commit is contained in:
Eike Ziller
2017-10-20 15:48:31 +02:00
parent 58c329cd03
commit 5639144466
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/classview/classviewmanager.cpp
View File

@@ -457,13 +457,13 @@ void Manager::gotoLocations(const QList<QVariant> &list)
int column; int column;
textEditor->convertPosition(textEditor->position(), &line, &column); textEditor->convertPosition(textEditor->position(), &line, &column);
SymbolLocation current(fileName, line, column); SymbolLocation current(fileName, line, column);
QSet<SymbolLocation>::const_iterator it = locations.find(current); QSet<SymbolLocation>::const_iterator it = locations.constFind(current);
QSet<SymbolLocation>::const_iterator end = locations.constEnd(); QSet<SymbolLocation>::const_iterator end = locations.constEnd();
if (it != end) { if (it != end) {
// we already are at the symbol, cycle to next location // we already are at the symbol, cycle to next location
++it; ++it;
if (it == end) if (it == end)
it = locations.begin(); it = locations.constBegin();
loc = *it; loc = *it;
} }
} }