From 566fa173b457826403b2f48cdd0a4a58ff975094 Mon Sep 17 00:00:00 2001 From: Andre Hartmann Date: Mon, 4 Jun 2012 17:22:50 +0200 Subject: [PATCH] Generic Project: Add some missing QLatin1String's. Change-Id: I0a3276dde7a3b8f90487c642d839611c80f53cf9 Reviewed-by: Daniel Teske --- .../genericprojectmanager/genericbuildconfiguration.cpp | 4 ++-- src/plugins/genericprojectmanager/genericmakestep.cpp | 4 ++-- src/plugins/genericprojectmanager/generictarget.cpp | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/plugins/genericprojectmanager/genericbuildconfiguration.cpp b/src/plugins/genericprojectmanager/genericbuildconfiguration.cpp index 8f37bfc8776..56fde6ba6bf 100644 --- a/src/plugins/genericprojectmanager/genericbuildconfiguration.cpp +++ b/src/plugins/genericprojectmanager/genericbuildconfiguration.cpp @@ -188,12 +188,12 @@ BuildConfiguration *GenericBuildConfigurationFactory::create(ProjectExplorer::Ta Q_ASSERT(buildSteps); GenericMakeStep *makeStep = new GenericMakeStep(buildSteps); buildSteps->insertStep(0, makeStep); - makeStep->setBuildTarget("all", /* on = */ true); + makeStep->setBuildTarget(QLatin1String("all"), /* on = */ true); Q_ASSERT(cleanSteps); GenericMakeStep *cleanMakeStep = new GenericMakeStep(cleanSteps); cleanSteps->insertStep(0, cleanMakeStep); - cleanMakeStep->setBuildTarget("clean", /* on = */ true); + cleanMakeStep->setBuildTarget(QLatin1String("clean"), /* on = */ true); cleanMakeStep->setClean(true); target->addBuildConfiguration(bc); // also makes the name unique... diff --git a/src/plugins/genericprojectmanager/genericmakestep.cpp b/src/plugins/genericprojectmanager/genericmakestep.cpp index ad2b0b24ee7..37dcc2566dd 100644 --- a/src/plugins/genericprojectmanager/genericmakestep.cpp +++ b/src/plugins/genericprojectmanager/genericmakestep.cpp @@ -331,9 +331,9 @@ ProjectExplorer::BuildStep *GenericMakeStepFactory::create(ProjectExplorer::Buil GenericMakeStep *step = new GenericMakeStep(parent); if (parent->id() == Core::Id(ProjectExplorer::Constants::BUILDSTEPS_CLEAN)) { step->setClean(true); - step->setBuildTarget("clean", /* on = */ true); + step->setBuildTarget(QLatin1String("clean"), /* on = */ true); } else if (parent->id() == Core::Id(ProjectExplorer::Constants::BUILDSTEPS_BUILD)) { - step->setBuildTarget("all", /* on = */ true); + step->setBuildTarget(QLatin1String("all"), /* on = */ true); } return step; } diff --git a/src/plugins/genericprojectmanager/generictarget.cpp b/src/plugins/genericprojectmanager/generictarget.cpp index d876dcdac80..8255a8b5b3b 100644 --- a/src/plugins/genericprojectmanager/generictarget.cpp +++ b/src/plugins/genericprojectmanager/generictarget.cpp @@ -131,18 +131,18 @@ GenericTarget *GenericTargetFactory::create(ProjectExplorer::Project *parent, co // Set up BuildConfiguration: GenericBuildConfiguration *bc = new GenericBuildConfiguration(t); - bc->setDisplayName("all"); + bc->setDisplayName(QLatin1String("all")); ProjectExplorer::BuildStepList *buildSteps = bc->stepList(ProjectExplorer::Constants::BUILDSTEPS_BUILD); ProjectExplorer::BuildStepList *cleanSteps = bc->stepList(ProjectExplorer::Constants::BUILDSTEPS_CLEAN); GenericMakeStep *makeStep = new GenericMakeStep(buildSteps); buildSteps->insertStep(0, makeStep); - makeStep->setBuildTarget("all", /* on = */ true); + makeStep->setBuildTarget(QLatin1String("all"), /* on = */ true); GenericMakeStep *cleanMakeStep = new GenericMakeStep(cleanSteps); cleanSteps->insertStep(0, cleanMakeStep); - cleanMakeStep->setBuildTarget("clean", /* on = */ true); + cleanMakeStep->setBuildTarget(QLatin1String("clean"), /* on = */ true); cleanMakeStep->setClean(true); bc->setBuildDirectory(genericproject->projectDirectory());