feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Valgrind: Add toolargs to command, not to a string list

Browse Source 
Removes arg splitting/re-combination roundtrips.

Change-Id: I4bc19d3b65f4c685140cea0e190191587f5124e6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This commit is contained in:
hjk
2023-05-23 18:49:32 +02:00
parent 0d22680c7c
commit 5689f0c60e
5 changed files with 24 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/valgrind/valgrindengine.cpp
View File

@@ -74,9 +74,9 @@ void ValgrindToolRunner::start()
m_progress.reportStarted();
CommandLine valgrind{valgrindExecutable};
valgrind.addArgs(m_settings.valgrindArguments.value(), CommandLine::Raw);
valgrind.addArgs(m_settings.valgrindArguments(), CommandLine::Raw);
valgrind.addArgs(genericToolArguments());
valgrind.addArgs(toolArguments());
addToolArguments(valgrind);
m_runner.setValgrindCommand(valgrind);
m_runner.setDebuggee(runControl()->runnable());