feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Revert "Clang: Reparse the translation unit for unsaved file changes"

Browse Source 
We reparse before every code completion so this code can be removed. We
will reuse some of it later.

This reverts commit 2443f18b85.

Change-Id: Ifcadfaa09b87ce5b58bfe5fe3cbaa2a86a59c5a6
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
This commit is contained in:
Marco Bubke
2015-07-20 17:28:55 +00:00
parent f11d5791a4
commit 568d7e7c7d
3 changed files with 18 additions and 114 deletions
Download Patch File Download Diff File Expand all files Collapse all files

66
tests/unit/unittest/translationunittest.cpp
View File

@@ -132,75 +132,15 @@ TEST(TranslationUnit, ResetedTranslationUnitIsNull)
ASSERT_TRUE(translationUnit.isNull());
}
TEST(TranslationUnit, TimeStampForProjectPartChangeIsUpdatedAsNewCxTranslationUnitIsGenerated)
TEST(TranslationUnit, TimeStampIsUpdatedAsNewCxTranslationUnitIsGenerated)
{
TranslationUnit translationUnit(Utf8StringLiteral(TESTDATA_DIR"/complete_testfile_1.cpp"), UnsavedFiles(), ProjectPart(Utf8StringLiteral("/path/to/projectfile")));
auto lastChangeTimePoint = translationUnit.lastProjectPartChangeTimePoint();
auto lastChangeTimePoint = translationUnit.lastChangeTimePoint();
std::this_thread::sleep_for(std::chrono::steady_clock::duration(1));
translationUnit.cxTranslationUnit();
ASSERT_THAT(translationUnit.lastProjectPartChangeTimePoint(), Gt(lastChangeTimePoint));
}
TEST(TranslationUnit, TimeStampForProjectPartChangeIsUpdatedAsProjectPartIsCleared)
{
ProjectPart projectPart(Utf8StringLiteral("/path/to/projectfile"));
TranslationUnit translationUnit(Utf8StringLiteral(TESTDATA_DIR"/complete_testfile_1.cpp"), UnsavedFiles(), projectPart);
translationUnit.cxTranslationUnit();
auto lastChangeTimePoint = translationUnit.lastProjectPartChangeTimePoint();
std::this_thread::sleep_for(std::chrono::steady_clock::duration(1));
projectPart.clear();
translationUnit.cxTranslationUnit();
ASSERT_THAT(translationUnit.lastProjectPartChangeTimePoint(), Gt(lastChangeTimePoint));
}
TEST(TranslationUnit, ReparseIsNeededAfterUnsavedFilesAreChanged)
{
UnsavedFiles unsavedFiles;
TranslationUnit translationUnit(Utf8StringLiteral(TESTDATA_DIR"/complete_testfile_1.cpp"),
unsavedFiles,
ProjectPart(Utf8StringLiteral("/path/to/projectfile")));
translationUnit.cxTranslationUnit();
unsavedFiles.clear();
translationUnit.cxTranslationUnit();
unsavedFiles.clear();
ASSERT_TRUE(translationUnit.isNeedingReparse());
}
TEST(TranslationUnit, NeedsNoReparseAfterUnsavedFilesAreNotChanged)
{
UnsavedFiles unsavedFiles;
TranslationUnit translationUnit(Utf8StringLiteral(TESTDATA_DIR"/complete_testfile_1.cpp"),
unsavedFiles,
ProjectPart(Utf8StringLiteral("/path/to/projectfile")));
translationUnit.cxTranslationUnit();
unsavedFiles.clear();
translationUnit.cxTranslationUnit();
ASSERT_FALSE(translationUnit.isNeedingReparse());
}
TEST(TranslationUnit, TimeStampForUnsavedFilesChange)
{
UnsavedFiles unsavedFiles;
TranslationUnit translationUnit(Utf8StringLiteral(TESTDATA_DIR"/complete_testfile_1.cpp"),
unsavedFiles,
ProjectPart(Utf8StringLiteral("/path/to/projectfile")));
translationUnit.cxTranslationUnit();
unsavedFiles.clear();
translationUnit.cxTranslationUnit();
auto lastChangeTimePoint = translationUnit.lastUnsavedFilesChangeTimePoint();
std::this_thread::sleep_for(std::chrono::steady_clock::duration(1));
unsavedFiles.clear();
translationUnit.cxTranslationUnit();
ASSERT_THAT(translationUnit.lastUnsavedFilesChangeTimePoint(), Gt(lastChangeTimePoint));
ASSERT_THAT(translationUnit.lastChangeTimePoint(), Gt(lastChangeTimePoint));
}