From 56a8cd6835cde92f453c13d5691d5b95362b9c2d Mon Sep 17 00:00:00 2001 From: Nikolai Kosjar Date: Wed, 4 Apr 2018 08:58:22 +0200 Subject: [PATCH] Clang: Remove pointless empty line in diagnostic tooltip widget ...for diagnostics coming from clazy/tidy. Change-Id: I73a1db74f075c1ec15ff16fc07da012451729097 Reviewed-by: Ivan Donchevskii --- src/plugins/clangcodemodel/clangdiagnostictooltipwidget.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/plugins/clangcodemodel/clangdiagnostictooltipwidget.cpp b/src/plugins/clangcodemodel/clangdiagnostictooltipwidget.cpp index 62870880fdf..61927604296 100644 --- a/src/plugins/clangcodemodel/clangdiagnostictooltipwidget.cpp +++ b/src/plugins/clangcodemodel/clangdiagnostictooltipwidget.cpp @@ -165,7 +165,9 @@ private: QString text; - if (m_displayHints.showCategoryAndEnableOption) + // Diagnostics from clazy/tidy do not have any category or option set, so + // avoid to add an empty line. + if (m_displayHints.showCategoryAndEnableOption && !diagnostic.category().isEmpty()) text.append(diagnosticCategoryAndEnableOptionRow(diagnostic)); text.append(diagnosticRow(diagnostic, IndentMode::DoNotIndent)); text.append(diagnosticRowsForChildren(diagnostic));