From 56e684fc37c77c7a161f5bcc3eed3cbd0a23bd2b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20Kundr=C3=A1t?= Date: Thu, 10 Nov 2016 10:57:58 +0100 Subject: [PATCH] Fix readability of TODO entries on dark themes The TODO plugin provides default values for color-coding backgrounds based on the severity of each item. These colors are rather light, and there is just one default with no theme awareness. It is a bug to use a theme-aware text color on a fixed-color background -- just switch to a dark theme such as flat-dark and observe the unreadability. This patch simply ensures that the default settings have reasonable readability. These defaults are still not theme-aware, but at least they are consistent. Change-Id: Ibf35a241c70e0f1ea001b55f84fd2e1dd1a0a2ea Reviewed-by: Alessandro Portale --- share/qtcreator/themes/flat-dark.creatortheme | 2 +- share/qtcreator/themes/flat-light.creatortheme | 2 +- share/qtcreator/themes/flat.creatortheme | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/share/qtcreator/themes/flat-dark.creatortheme b/share/qtcreator/themes/flat-dark.creatortheme index bf3b181a28f..5e8f7d3e11f 100644 --- a/share/qtcreator/themes/flat-dark.creatortheme +++ b/share/qtcreator/themes/flat-dark.creatortheme @@ -124,7 +124,7 @@ TextColorHighlight=ffff0000 TextColorLink=textColorLink TextColorLinkVisited=textColorLinkVisited TextColorNormal=text -TodoItemTextColor=text +TodoItemTextColor=ff000000 ToggleButtonBackgroundColor=shadowBackground ToolBarBackgroundColor=shadowBackground TreeViewArrowColorNormal=hoverBackground diff --git a/share/qtcreator/themes/flat-light.creatortheme b/share/qtcreator/themes/flat-light.creatortheme index ae978557363..18746658a13 100644 --- a/share/qtcreator/themes/flat-light.creatortheme +++ b/share/qtcreator/themes/flat-light.creatortheme @@ -122,7 +122,7 @@ TextColorHighlight=ffff0000 TextColorLink=ff007af4 TextColorLinkVisited=ffa57aff TextColorNormal=text -TodoItemTextColor=text +TodoItemTextColor=ff000000 ToggleButtonBackgroundColor=shadowBackground ToolBarBackgroundColor=shadowBackground TreeViewArrowColorNormal=hoverBackground diff --git a/share/qtcreator/themes/flat.creatortheme b/share/qtcreator/themes/flat.creatortheme index a4790bbbcc4..472353a6ac7 100644 --- a/share/qtcreator/themes/flat.creatortheme +++ b/share/qtcreator/themes/flat.creatortheme @@ -120,7 +120,7 @@ TextColorHighlight=ffff0000 TextColorLink=ff007af4 TextColorLinkVisited=ffa57aff TextColorNormal=text -TodoItemTextColor=text +TodoItemTextColor=ff000000 ToggleButtonBackgroundColor=shadowBackground ToolBarBackgroundColor=shadowBackground TreeViewArrowColorNormal=hoverBackground