feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

LSP: rerequest completion if contents change while processing

Browse Source 
Task-number: QTCREATORBUG-21108
Change-Id: I6ca7920e7099dba0ba1bc953a2e6296bd86c1dc1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
David Schulz
2018-09-20 14:31:50 +02:00
parent 279a11f46b
commit 5719adc47c
3 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/plugins/texteditor/codeassist/codeassistant.cpp
View File

@@ -245,10 +245,17 @@ void CodeAssistantPrivate::requestProposal(AssistReason reason,
case IAssistProvider::Asynchronous: {
processor->setAsyncCompletionAvailableHandler(
[this, reason](IAssistProposal *newProposal){
invalidateCurrentRequestData();
displayProposal(newProposal, reason);
if (m_asyncProcessor && m_asyncProcessor->needsRestart() && m_receivedContentWhileWaiting) {
delete newProposal;
m_receivedContentWhileWaiting = false;
invalidateCurrentRequestData();
requestProposal(reason, m_assistKind, m_requestProvider);
} else {
invalidateCurrentRequestData();
displayProposal(newProposal, reason);
emit q->finished();
emit q->finished();
}
});
// If there is a proposal, nothing asynchronous happened...