DAP: Add attach function to gdb dap engine

Change-Id: Id1c886cf3bbdbf85d4eed39f288107fc71317496
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>

src/plugins/debugger/dap/dapengine.cpp

@@ -120,7 +120,16 @@ void DapEngine::handleDapStarted()
     qCDebug(dapEngineLog) << "handleDapStarted";
 }
 
-void DapEngine::handleDapConfigurationDone()
+void DapEngine::handleDapInitialize()
+{
+    QTC_ASSERT(state() == EngineRunRequested, qCDebug(dapEngineLog) << state());
+
+    m_dapClient->sendLaunch(runParameters().inferior.command.executable());
+
+    qCDebug(dapEngineLog) << "handleDapLaunch";
+}
+
+void DapEngine::handleDapEventInitialized()
 {
     QTC_ASSERT(state() == EngineRunRequested, qCDebug(dapEngineLog) << state());
 
@@ -129,14 +138,9 @@ void DapEngine::handleDapConfigurationDone()
     qCDebug(dapEngineLog) << "handleDapConfigurationDone";
 }
 
-
+void DapEngine::handleDapConfigurationDone()
-void DapEngine::handleDapInitialize()
 {
-    QTC_ASSERT(state() == EngineRunRequested, qCDebug(dapEngineLog) << state());
+    notifyEngineRunAndInferiorRunOk();
-
-    m_dapClient->sendLaunch(runParameters().inferior.command.executable());
-
-    qCDebug(dapEngineLog) << "handleDapLaunch";
 }
 
 void DapEngine::interruptInferior()
@@ -480,6 +484,12 @@ void DapEngine::handleResponse(DapResponseType type, const QJsonObject &response
 {
     const QString command = response.value("command").toString();
 
+    if (response.contains("success") && !response.value("success").toBool()) {
+        showMessage(QString("DAP COMMAND FAILED: %1").arg(command));
+        qCDebug(dapEngineLog) << "DAP COMMAND FAILED:" << command;
+        return;
+    }
+
     switch (type) {
     case DapResponseType::Initialize:
         qCDebug(dapEngineLog) << "initialize success";
@@ -488,7 +498,7 @@ void DapEngine::handleResponse(DapResponseType type, const QJsonObject &response
     case DapResponseType::ConfigurationDone:
         showMessage("configurationDone", LogDebug);
         qCDebug(dapEngineLog) << "configurationDone success";
-        notifyEngineRunAndInferiorRunOk();
+        handleDapConfigurationDone();
         break;
     case DapResponseType::Continue:
         showMessage("continue", LogDebug);
@@ -597,7 +607,7 @@ void DapEngine::handleEvent(DapEventType type, const QJsonObject &event)
     case DapEventType::Initialized:
         qCDebug(dapEngineLog) << "initialize success";
         claimInitialBreakpoints();
-        handleDapConfigurationDone();
+        handleDapEventInitialized();
         break;
     case DapEventType::Stopped:
         handleStoppedEvent(event);

src/plugins/debugger/dap/dapengine.h

@@ -85,7 +85,8 @@ protected:
 
     void handleDapStarted();
     virtual void handleDapInitialize();
-    void handleDapConfigurationDone();
+    void handleDapEventInitialized();
+    virtual void handleDapConfigurationDone();
 
     void dapRemoveBreakpoint(const Breakpoint &bp);
     void dapInsertBreakpoint(const Breakpoint &bp);

src/plugins/debugger/dap/gdbdapengine.cpp

@@ -93,12 +93,43 @@ GdbDapEngine::GdbDapEngine()
     setDebuggerType("DAP");
 }
 
+void GdbDapEngine::handleDapInitialize()
+{
+    if (!isLocalAttachEngine()) {
+        DapEngine::handleDapInitialize();
+        return;
+    }
+
+    QTC_ASSERT(state() == EngineRunRequested, qCDebug(dapEngineLog) << state());
+    m_dapClient->postRequest("attach", QJsonObject{{"__restart", ""}});
+    qCDebug(dapEngineLog) << "handleDapAttach";
+}
+
+
+bool GdbDapEngine::isLocalAttachEngine() const
+{
+    return runParameters().startMode == AttachToLocalProcess;
+}
+
+void GdbDapEngine::handleDapConfigurationDone()
+{
+    if (!isLocalAttachEngine()) {
+        DapEngine::handleDapConfigurationDone();
+        return;
+    }
+
+    notifyEngineRunAndInferiorStopOk();
+}
+
 void GdbDapEngine::setupEngine()
 {
     QTC_ASSERT(state() == EngineSetupRequested, qCDebug(dapEngineLog) << state());
 
     const DebuggerRunParameters &rp = runParameters();
-    const CommandLine cmd{rp.debugger.command.executable(), {"-i", "dap"}};
+    CommandLine cmd{rp.debugger.command.executable(), {"-i", "dap"}};
+
+    if (isLocalAttachEngine())
+        cmd.addArgs({"-p", QString::number(rp.attachPID.pid())});
 
     QVersionNumber oldestVersion(14, 0, 50);
     QVersionNumber version = QVersionNumber::fromString(rp.version);

src/plugins/debugger/dap/gdbdapengine.h

@@ -14,6 +14,11 @@ public:
 
 private:
     void setupEngine() override;
+
+    void handleDapInitialize() override;
+    void handleDapConfigurationDone() override;
+
+    bool isLocalAttachEngine() const;
 };
 
 } // Debugger::Internal

src/plugins/debugger/dap/pydapengine.cpp

@@ -88,6 +88,8 @@ public:
         connect(m_timer, &QTimer::timeout, this, [this]() {
             m_socket.connectToHost(m_hostName, m_port);
             m_socket.waitForConnected();
+            qCDebug(dapEngineLog) << "proc id" << m_proc.processId();
+
             if (m_socket.state() == QTcpSocket::ConnectedState)
                 m_timer->stop();