feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Fix potential crash

Browse Source 
Change-Id: I85e5b7d8f03e270540294a20ccc24658943a2c9b
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Thomas Hartmann
2022-05-31 17:59:23 +02:00
parent ffe94d177c
commit 57cb9d888b
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/qmldesigner/components/itemlibrary/itemlibrarycategoriesmodel.cpp
View File

@@ -207,10 +207,11 @@ void ItemLibraryCategoriesModel::clearSelectedCategory(int categoryIndex)
QPointer<ItemLibraryCategory> ItemLibraryCategoriesModel::selectCategory(int categoryIndex) QPointer<ItemLibraryCategory> ItemLibraryCategoriesModel::selectCategory(int categoryIndex)
{ {
if (categoryIndex == -1 || m_categoryList.isEmpty()) if (m_categoryList.isEmpty() || categoryIndex < 0 || categoryIndex >= m_categoryList.size())
return nullptr; return nullptr;
const QPointer<ItemLibraryCategory> category = m_categoryList.at(categoryIndex); const QPointer<ItemLibraryCategory> category = m_categoryList.at(categoryIndex);
if (!category->categorySelected()) { if (!category->categorySelected()) {
category->setCategorySelected(true); category->setCategorySelected(true);
emit dataChanged(index(categoryIndex),index(categoryIndex), {m_roleNames.key("categorySelected")}); emit dataChanged(index(categoryIndex),index(categoryIndex), {m_roleNames.key("categorySelected")});