From 57e3a0353860c56546fbb3475f6fd1adec65cc46 Mon Sep 17 00:00:00 2001
From: Christian Kandeler <christian.kandeler@qt.io>
Date: Tue, 21 Jan 2020 12:50:44 +0100
Subject: [PATCH] QtSupport: Fix partial delete of ExampleItem objects

If we delete items via the base class destructor, it needs to be
virtual.

Change-Id: Id5deaa3f327d881b93852b5cbf1cf2940bb333d0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
---
 src/plugins/coreplugin/welcomepagehelper.h | 1 +
 src/plugins/qtsupport/exampleslistmodel.h  | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/src/plugins/coreplugin/welcomepagehelper.h b/src/plugins/coreplugin/welcomepagehelper.h
index 117535a4bba..884d64de8df 100644
--- a/src/plugins/coreplugin/welcomepagehelper.h
+++ b/src/plugins/coreplugin/welcomepagehelper.h
@@ -88,6 +88,7 @@ private:
 class CORE_EXPORT ListItem
 {
 public:
+    virtual ~ListItem() {}
     QString name;
     QString description;
     QString imageUrl;
diff --git a/src/plugins/qtsupport/exampleslistmodel.h b/src/plugins/qtsupport/exampleslistmodel.h
index 80b0a8fe333..4c92dfef3ff 100644
--- a/src/plugins/qtsupport/exampleslistmodel.h
+++ b/src/plugins/qtsupport/exampleslistmodel.h
@@ -103,6 +103,8 @@ enum InstructionalType
 class ExampleItem : public Core::ListItem
 {
 public:
+    ~ExampleItem() override {}
+
     QString projectPath;
     QString docUrl;
     QStringList filesToOpen;