debugger: move qml engine private classes to internal namespace

This commit is contained in:
hjk
2010-11-22 10:20:31 +01:00
parent 7fbff9c3af
commit 585bb50d89
4 changed files with 29 additions and 25 deletions

View File

@@ -10,11 +10,10 @@
#include <QtCore/QTimer> #include <QtCore/QTimer>
namespace Debugger { namespace Debugger {
namespace Internal {
const int ConnectionWaitTimeMs = 5000; const int ConnectionWaitTimeMs = 5000;
namespace Internal {
DebuggerEngine *createCdbEngine(const DebuggerStartParameters &, QString *); DebuggerEngine *createCdbEngine(const DebuggerStartParameters &, QString *);
DebuggerEngine *createGdbEngine(const DebuggerStartParameters &); DebuggerEngine *createGdbEngine(const DebuggerStartParameters &);
DebuggerEngine *createQmlEngine(const DebuggerStartParameters &); DebuggerEngine *createQmlEngine(const DebuggerStartParameters &);
@@ -28,14 +27,13 @@ DebuggerEngine *createQmlCppEngine(const DebuggerStartParameters &sp)
return 0; return 0;
} }
} // namespace Internal class QmlCppEnginePrivate
{
class QmlCppEnginePrivate {
public: public:
QmlCppEnginePrivate(); QmlCppEnginePrivate();
~QmlCppEnginePrivate() {} ~QmlCppEnginePrivate() {}
friend class QmlCppEngine; friend class Debugger::QmlCppEngine;
private: private:
QmlEngine *m_qmlEngine; QmlEngine *m_qmlEngine;
DebuggerEngine *m_cppEngine; DebuggerEngine *m_cppEngine;
@@ -43,13 +41,16 @@ private:
DebuggerState m_errorState; DebuggerState m_errorState;
}; };
QmlCppEnginePrivate::QmlCppEnginePrivate() : QmlCppEnginePrivate::QmlCppEnginePrivate()
m_qmlEngine(0), : m_qmlEngine(0),
m_cppEngine(0), m_cppEngine(0),
m_activeEngine(0), m_activeEngine(0),
m_errorState(InferiorRunOk) m_errorState(InferiorRunOk)
{ {}
}
} // namespace Internal
using namespace Internal;
QmlCppEngine::QmlCppEngine(const DebuggerStartParameters &sp) QmlCppEngine::QmlCppEngine(const DebuggerStartParameters &sp)
: DebuggerEngine(sp), d(new QmlCppEnginePrivate) : DebuggerEngine(sp), d(new QmlCppEnginePrivate)
@@ -640,4 +641,5 @@ DebuggerEngine *QmlCppEngine::cppEngine() const
return d->m_cppEngine; return d->m_cppEngine;
} }
} // namespace Debugger } // namespace Debugger

View File

@@ -11,7 +11,9 @@ class IEditor;
namespace Debugger { namespace Debugger {
namespace Internal {
class QmlCppEnginePrivate; class QmlCppEnginePrivate;
} // namespace Internal
class DEBUGGER_EXPORT QmlCppEngine : public DebuggerEngine class DEBUGGER_EXPORT QmlCppEngine : public DebuggerEngine
{ {
@@ -112,7 +114,7 @@ private:
void engineStateChanged(const DebuggerState &newState); void engineStateChanged(const DebuggerState &newState);
private: private:
QScopedPointer<QmlCppEnginePrivate> d; QScopedPointer<Internal::QmlCppEnginePrivate> d;
}; };
} // namespace Debugger } // namespace Debugger

View File

@@ -141,27 +141,27 @@ static QDataStream &operator>>(QDataStream &s, StackFrame &frame)
return s; return s;
} }
} // namespace Internal
class QmlEnginePrivate
using namespace Internal; {
class QmlEnginePrivate {
public: public:
explicit QmlEnginePrivate(QmlEngine *q); explicit QmlEnginePrivate(QmlEngine *q);
~QmlEnginePrivate() { delete m_adapter; }
friend class QmlEngine; friend class Debugger::QmlEngine;
private: private:
int m_ping; int m_ping;
QmlAdapter *m_adapter; QmlAdapter *m_adapter;
ProjectExplorer::ApplicationLauncher m_applicationLauncher; ProjectExplorer::ApplicationLauncher m_applicationLauncher;
}; };
QmlEnginePrivate::QmlEnginePrivate(QmlEngine *q) : QmlEnginePrivate::QmlEnginePrivate(QmlEngine *q)
m_ping(0) : m_ping(0), m_adapter(new QmlAdapter(q))
, m_adapter(new QmlAdapter(q)) {}
{
} } // namespace Internal
using namespace Internal;
/////////////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////////////
// //
@@ -177,7 +177,6 @@ QmlEngine::QmlEngine(const DebuggerStartParameters &startParameters)
QmlEngine::~QmlEngine() QmlEngine::~QmlEngine()
{ {
delete d->m_adapter;
} }
void QmlEngine::gotoLocation(const QString &fileName, int lineNumber, bool setMarker) void QmlEngine::gotoLocation(const QString &fileName, int lineNumber, bool setMarker)

View File

@@ -36,9 +36,10 @@
#include <QtNetwork/QAbstractSocket> #include <QtNetwork/QAbstractSocket>
namespace Debugger { namespace Debugger {
class QmlAdapter;
namespace Internal {
class QmlEnginePrivate; class QmlEnginePrivate;
} // namespace Internal
class DEBUGGER_EXPORT QmlEngine : public DebuggerEngine class DEBUGGER_EXPORT QmlEngine : public DebuggerEngine
{ {
@@ -140,7 +141,7 @@ private:
private: private:
friend class QmlCppEngine; friend class QmlCppEngine;
QScopedPointer<QmlEnginePrivate> d; QScopedPointer<Internal::QmlEnginePrivate> d;
}; };
} // namespace Debugger } // namespace Debugger