feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix change-of-sign warning found by ICC

Browse Source 
-1 is not a valid unsigned value.

registerhandler.cpp(354): warning #68: integer conversion resulted in a change of sign
          return createIndex(row, col, TopLevelId);
                                       ^

Change-Id: I41935255704f19724d6cec16ea470e2f8f8a16a1
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
This commit is contained in:
Thiago Macieira
2013-12-05 23:29:37 -08:00
parent 1ff3a8287d
commit 58a4e601ff
5 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/debugger/debuggerprotocol.cpp
View File

@@ -50,7 +50,7 @@ uchar fromhex(uchar c)
return 10 + c - 'a';
if (c >= 'A' && c <= 'Z')
return 10 + c - 'A';
return -1;
return UCHAR_MAX;
}
void skipCommas(const char *&from, const char *to)
@@ -141,7 +141,7 @@ QByteArray GdbMi::parseCString(const char *&from, const char *to)
uchar prod = 0;
while (true) {
uchar val = fromhex(c);
if (val == uchar(-1))
if (val == UCHAR_MAX)
break;
prod = prod * 16 + val;
if (++chars == 3 || src == end)