feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

PerfProfiler: Remove PerfProfilerRunner::start() reimplementation

Browse Source 
Move the code into c'tor.

Change-Id: Ic7132f985890dc70fe6144934cef4fe4dd4ec308
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2025-01-03 12:35:52 +01:00
parent e37b7efdee
commit 58bff457d7
1 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/perfprofiler/perfprofilerruncontrol.cpp
View File

@@ -126,15 +126,12 @@ public:
m_perfParserWorker->addStartDependency(m_perfRecordWorker); m_perfParserWorker->addStartDependency(m_perfRecordWorker);
m_perfParserWorker->addStopDependency(m_perfRecordWorker); m_perfParserWorker->addStopDependency(m_perfRecordWorker);
PerfProfilerTool::instance()->onWorkerCreation(runControl); PerfProfilerTool::instance()->onWorkerCreation(runControl);
}
void start() final
{
auto tool = PerfProfilerTool::instance(); auto tool = PerfProfilerTool::instance();
connect(tool->stopAction(), &QAction::triggered, runControl(), &RunControl::initiateStop); connect(tool->stopAction(), &QAction::triggered, runControl, &RunControl::initiateStop);
connect(runControl(), &RunControl::started, PerfProfilerTool::instance(), connect(runControl, &RunControl::started, PerfProfilerTool::instance(),
&PerfProfilerTool::onRunControlStarted); &PerfProfilerTool::onRunControlStarted);
connect(runControl(), &RunControl::stopped, PerfProfilerTool::instance(), connect(runControl, &RunControl::stopped, PerfProfilerTool::instance(),
&PerfProfilerTool::onRunControlFinished); &PerfProfilerTool::onRunControlFinished);
PerfDataReader *reader = m_perfParserWorker->reader(); PerfDataReader *reader = m_perfParserWorker->reader();
@@ -143,8 +140,6 @@ public:
if (!reader->feedParser(data)) if (!reader->feedParser(data))
reportFailure(Tr::tr("Failed to transfer Perf data to perfparser.")); reportFailure(Tr::tr("Failed to transfer Perf data to perfparser."));
}); });
reportStarted();
} }
private: private: