feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

LoadCoreDialog: only try reading from existing corefile

Browse Source 
- currently gdb is called on every change of the core file, i.e. on
  every keypress when typing a path. Changed to only do that when the
  file exists

Change-Id: I27f1c21b2561420d72f273244dc6a1bb5fb8bfe7
Reviewed-by: hjk <hjk121@nokiamail.com>
This commit is contained in:
Thomas Otto
2014-07-23 11:59:49 +02:00
committed by hjk
parent de5f0a7613
commit 590ccce734
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/debugger/loadcoredialog.cpp
View File

@@ -363,7 +363,7 @@ bool AttachCoreDialog::useLocalCoreFile() const
void AttachCoreDialog::coreFileChanged(const QString &core) void AttachCoreDialog::coreFileChanged(const QString &core)
{ {
if (!Utils::HostOsInfo::isWindowsHost()) { if (!Utils::HostOsInfo::isWindowsHost() && QFileInfo::exists(core)) {
Kit *k = d->kitChooser->currentKit(); Kit *k = d->kitChooser->currentKit();
QTC_ASSERT(k, return); QTC_ASSERT(k, return);
FileName cmd = DebuggerKitInformation::debuggerCommand(k); FileName cmd = DebuggerKitInformation::debuggerCommand(k);