From 5943152f65a964418321c62572c29a73036a7fa6 Mon Sep 17 00:00:00 2001 From: Alessandro Portale Date: Thu, 4 May 2023 13:00:00 +0200 Subject: [PATCH] Android: Remove CheckableMessageBox::shouldAskAgain check Most likely, that was checked in addition to InfoBar::canInfoBeAdded in order to be settings compatible with QtC versions prior to the migration from CheckableMessageBox to InfoBar. But that is at this point 4 Years ago, and should be removed because it causes confusion when reading the code. Change-Id: I76ae6a9ed0c8f9f7fa20b64090d89724588511ed Reviewed-by: Assam Boudjelthia Reviewed-by: Reviewed-by: Marcus Tillmanns --- src/plugins/android/androidplugin.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/plugins/android/androidplugin.cpp b/src/plugins/android/androidplugin.cpp index 04e9609b85e..c15cfef221d 100644 --- a/src/plugins/android/androidplugin.cpp +++ b/src/plugins/android/androidplugin.cpp @@ -153,8 +153,7 @@ void AndroidPlugin::kitsRestored() void AndroidPlugin::askUserAboutAndroidSetup() { - if (!Utils::CheckableMessageBox::shouldAskAgain(Core::ICore::settings(), kSetupAndroidSetting) - || !Core::ICore::infoBar()->canInfoBeAdded(kSetupAndroidSetting)) + if (!Core::ICore::infoBar()->canInfoBeAdded(kSetupAndroidSetting)) return; Utils::InfoBarEntry