From 594edc49dcf7b4692fea1f5f79d690475402360d Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Tue, 10 Dec 2024 16:04:34 +0100 Subject: [PATCH] Kit aspects: Make sure to always use createSubWidget() ... to create sub-widgets. Otherwise, parts of the aspect will stay visible when it gets hidden. Change-Id: I967ef745348c10f7b5e78d726efcdb9c6005f887 Reviewed-by: hjk --- .../projectexplorer/devicesupport/devicekitaspects.cpp | 4 ++-- src/plugins/qtsupport/qtkitaspect.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/plugins/projectexplorer/devicesupport/devicekitaspects.cpp b/src/plugins/projectexplorer/devicesupport/devicekitaspects.cpp index 0c0f067d03f..367045b4717 100644 --- a/src/plugins/projectexplorer/devicesupport/devicekitaspects.cpp +++ b/src/plugins/projectexplorer/devicesupport/devicekitaspects.cpp @@ -99,9 +99,9 @@ private: { if (const QList embedded = aspectsToEmbed(); !embedded.isEmpty()) { Layouting::Layout box(new QHBoxLayout); - box.addItem(Tr::tr("Type:")); + box.addItem(createSubWidget(Tr::tr("Type:"))); embedded.first()->addToInnerLayout(box); - box.addItem(Tr::tr("Device:")); + box.addItem(createSubWidget(Tr::tr("Device:"))); KitAspect::addToInnerLayout(box); QSizePolicy p = comboBoxes().first()->sizePolicy(); p.setHorizontalStretch(1); diff --git a/src/plugins/qtsupport/qtkitaspect.cpp b/src/plugins/qtsupport/qtkitaspect.cpp index b232d203579..a69c7997864 100644 --- a/src/plugins/qtsupport/qtkitaspect.cpp +++ b/src/plugins/qtsupport/qtkitaspect.cpp @@ -95,7 +95,7 @@ private: QSizePolicy p = comboBoxes().first()->sizePolicy(); p.setHorizontalStretch(2); comboBoxes().first()->setSizePolicy(p); - box.addItem(Tr::tr("Mkspec:")); + box.addItem(createSubWidget(Tr::tr("Mkspec:"))); embedded.first()->addToInnerLayout(box); layout.addItem(box); } else {