From 5954f9ba1651b3f99e817cd4fce3e32286e901ce Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Fri, 4 Oct 2024 09:13:16 +0200 Subject: [PATCH] Valgrind: Devirtualize some methods There are no subclasses of DataModel and CallModel, so no need to have virtual methods. Change-Id: Ibce461bba2e80e491844aaaf1593efdcf03f3a9e Reviewed-by: hjk --- src/plugins/valgrind/callgrind/callgrindcallmodel.h | 8 ++++---- src/plugins/valgrind/callgrind/callgrinddatamodel.h | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/plugins/valgrind/callgrind/callgrindcallmodel.h b/src/plugins/valgrind/callgrind/callgrindcallmodel.h index 4b8e6f631e4..22db3ec1596 100644 --- a/src/plugins/valgrind/callgrind/callgrindcallmodel.h +++ b/src/plugins/valgrind/callgrind/callgrindcallmodel.h @@ -26,11 +26,11 @@ public: /// Only one cost event column will be shown, this decides which one it is. /// By default it is the first event in the @c ParseData, i.e. 0. - virtual int costEvent() const; - virtual void setCostEvent(int event); + int costEvent() const; + void setCostEvent(int event); - virtual void setParseData(const ParseData *data); - virtual const ParseData *parseData() const; + void setParseData(const ParseData *data); + const ParseData *parseData() const; void setCalls(const QList &calls, const Function *function); QList calls() const; diff --git a/src/plugins/valgrind/callgrind/callgrinddatamodel.h b/src/plugins/valgrind/callgrind/callgrinddatamodel.h index 136ea4a0d7f..a5233519fab 100644 --- a/src/plugins/valgrind/callgrind/callgrinddatamodel.h +++ b/src/plugins/valgrind/callgrind/callgrinddatamodel.h @@ -20,15 +20,15 @@ public: DataModel(); ~DataModel() override; - virtual void setParseData(const ParseData *data); - virtual const ParseData *parseData() const; + void setParseData(const ParseData *data); + const ParseData *parseData() const; void setVerboseToolTipsEnabled(bool enabled); bool verboseToolTipsEnabled() const; /// Only one cost event column will be shown, this decides which one it is. /// By default it is the first event in the @c ParseData, i.e. 0. - virtual int costEvent() const; + int costEvent() const; int rowCount(const QModelIndex &parent = QModelIndex()) const override; int columnCount(const QModelIndex &parent = QModelIndex()) const override; @@ -61,7 +61,7 @@ public: /// Only one cost event column will be shown, this decides which one it is. /// By default it is the first event in the @c ParseData, i.e. 0. - virtual void setCostEvent(int event); + void setCostEvent(int event); private: class Private;